Skip to content

Commit 7afb9a5

Browse files
committed
Fix typo in ios_lint_localizations unsupported-format warning
Commit 9eabbb0 reworded the warning to "can only occurr" (a typo) without updating the spec, which still expected the prior "only make sense" text — leaving `ios_lint_localizations_spec.rb`'s "warns if input files are not in ASCII-plist format" example failing on `foundation`. Correct the spelling to "can only occur" and align the spec.
1 parent e155caf commit 7afb9a5

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_lint_localizations.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def self.find_duplicated_keys(params)
6262
duplicate_keys[language] = payload.map { |key, value| "`#{key}` was found at multiple lines: #{value.join(', ')}" } unless payload.empty?
6363
when :unsupported_format
6464
UI.important <<~WRONG_FORMAT
65-
File `#{path}` is in #{payload} format, while finding duplicate keys can only occurr on files that are in ASCII-plist format.
65+
File `#{path}` is in #{payload} format, while finding duplicate keys can only occur on files that are in ASCII-plist format.
6666
Since your files are in #{payload} format, you should probably disable the `check_duplicate_keys` option from this `#{action_name}` call.
6767
WRONG_FORMAT
6868
when :unscannable

spec/ios_lint_localizations_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def run_l10n_linter_test(data_file:, check_duplicate_keys: nil, fail_on_strings_
194194
File.write(File.join(fr_lproj, 'Localizable.strings'), File.read(xml_file))
195195

196196
expected_message = <<~EXPECTED_WARNING
197-
File `#{fr_lproj}/Localizable.strings` is in xml format, while finding duplicate keys only make sense on files that are in ASCII-plist format.
197+
File `#{fr_lproj}/Localizable.strings` is in xml format, while finding duplicate keys can only occur on files that are in ASCII-plist format.
198198
Since your files are in xml format, you should probably disable the `check_duplicate_keys` option from this `ios_lint_localizations` call.
199199
EXPECTED_WARNING
200200
expect(FastlaneCore::UI).to receive(:important).with(expected_message)

0 commit comments

Comments
 (0)