Revert pretty_json — rspec do nice diffs after all

Author: AliSoftware

spec/ios_send_app_size_metrics_spec.rb

@@ -4,12 +4,7 @@
   let(:test_data_dir) { File.join(File.dirname(__FILE__), 'test-data', 'app_size_metrics') }
   let(:mocked_endpoint) { 'https://localhost/api/metrics' }
   let(:mocked_token) { 'token/1' }
-
-  # Utility method to turn a minified JSON into a pretty-formatted JSON (without the GZIP fake prefix if any)
-  # To make any test failure and diff easier to debug
-  def pretty_json(json_string)
-    JSON.pretty_generate(JSON.parse(json_string))
-  end
+  let(:fake_ipa_size) { 1337 } # The value used in the `app-thinning.plist` and `app-size-metrics-payload.json` fixtures
 
   def test_app_size_action(fake_ipa_size:, expected_json:, **other_action_args)
     in_tmp_dir do |tmp_dir|
@@ -43,9 +38,9 @@ def test_app_size_action(fake_ipa_size:, expected_json:, **other_action_args)
       expect do
         last_received_body_uncompressed = Zlib.gunzip(last_received_body)
       end.not_to raise_error, 'Payload was not valid GZipped data'
-      # Compare the payloads as pretty-formatted JSON, to make the diff in test failures more readable if one happen
-      expect(pretty_json(last_received_body_uncompressed)).to eq(pretty_json(expected_json)), 'Decompressed JSON payload was not as expected'
-      # Compare the payloads as raw uncompressed data as a final check
+      # Compare the JSON payloads as parsed objects for nicer diffs
+      expect(JSON.parse(last_received_body_uncompressed)).to eq(JSON.parse(expected_json)), 'Decompressed JSON payload was not as expected'
+      # Compare the payloads as uncompressed, raw string as a final check
       expect(last_received_body_uncompressed).to eq(expected_json)
     end
   end
@@ -78,7 +73,7 @@ def test_app_size_action(fake_ipa_size:, expected_json:, **other_action_args)
     expected_json = JSON.parse(File.read(expected_fixture)).to_json
 
     test_app_size_action(
-      fake_ipa_size: 1337,
+      fake_ipa_size: fake_ipa_size,
       expected_json: expected_json,
       app_thinning_plist_path: app_thinning_plist_path,
       app_name: 'wordpress',