Group two related specs in common context

h/t @mokagio in #427 (comment)

Co-authored-by: Gio Lodi <giovanni.lodi42@gmail.com>

Author: AliSoftware

spec/upload_to_s3_spec.rb

@@ -144,37 +144,39 @@ def stub_s3_response_for_file(key, exists: true)
       end.to raise_error(FastlaneCore::Interface::FastlaneError, 'Path `this-file-does-not-exist.txt` does not exist.')
     end
 
-    it 'fails if the file already exists on S3 and skip_if_exists:false' do
-      expected_key = 'a62f2225bf70bfaccbc7f1ef2a397836717377de/key'
-      stub_s3_response_for_file(expected_key)
-
-      with_tmp_file(named: 'key') do |file_path|
-        expect do
-          run_described_fastlane_action(
-            bucket: test_bucket,
-            key: 'key',
-            file: file_path
-          )
-        end.to raise_error(FastlaneCore::Interface::FastlaneError, "File already exists in S3 bucket #{test_bucket} at #{expected_key}")
+    context 'when the file already exists on S3' do
+      it 'fails if skip_if_exists:false' do
+        expected_key = 'a62f2225bf70bfaccbc7f1ef2a397836717377de/key'
+        stub_s3_response_for_file(expected_key)
+
+        with_tmp_file(named: 'key') do |file_path|
+          expect do
+            run_described_fastlane_action(
+              bucket: test_bucket,
+              key: 'key',
+              file: file_path
+            )
+          end.to raise_error(FastlaneCore::Interface::FastlaneError, "File already exists in S3 bucket #{test_bucket} at #{expected_key}")
+        end
       end
-    end
 
-    it 'just logs if the file already exists on S3 and skip_if_exists:true' do
-      expected_key = 'a62f2225bf70bfaccbc7f1ef2a397836717377de/key'
-      stub_s3_response_for_file(expected_key)
+      it 'logs a message without failing if skip_if_exists:true' do
+        expected_key = 'a62f2225bf70bfaccbc7f1ef2a397836717377de/key'
+        stub_s3_response_for_file(expected_key)
 
-      warnings = []
-      allow(FastlaneCore::UI).to receive(:important) { |message| warnings << message }
+        warnings = []
+        allow(FastlaneCore::UI).to receive(:important) { |message| warnings << message }
 
-      with_tmp_file(named: 'key') do |file_path|
-        key = run_described_fastlane_action(
-          bucket: test_bucket,
-          key: 'key',
-          file: file_path,
-          skip_if_exists: true
-        )
-        expect(warnings).to eq(["File already exists in S3 bucket #{test_bucket} at #{expected_key}. Skipping upload."])
-        expect(key).to eq(expected_key)
+        with_tmp_file(named: 'key') do |file_path|
+          key = run_described_fastlane_action(
+            bucket: test_bucket,
+            key: 'key',
+            file: file_path,
+            skip_if_exists: true
+          )
+          expect(warnings).to eq(["File already exists in S3 bucket #{test_bucket} at #{expected_key}. Skipping upload."])
+          expect(key).to eq(expected_key)
+        end
       end
     end
   end