Remove usages of download_metadata.swift

Author: iangmaia

lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb

@@ -15,13 +15,12 @@ module GitHelper
         # @env PROJECT_NAME The name of the directory containing the project code (especially containing the Resources/ subfolder)
         #
         # @param [Bool] include_deliverfile If true (the default), includes the `fastlane/Deliverfile` in files being commited
-        # @param [Bool] include_metadata If true (the default), includes the `fastlane/download_metadata.swift` file and the `.pot` file (which typically contains an entry or release notes for the new version)
+        # @param [Bool] include_metadata If true (the default), includes the `.pot` file (which typically contains an entry or release notes for the new version)
         #
         def self.commit_version_bump(include_deliverfile: true, include_metadata: true)
           files_list = [File.join(get_project_root(), 'config', '.')]
           files_list.append File.join('fastlane', 'Deliverfile') if include_deliverfile
           if include_metadata
-            files_list.append File.join('fastlane', 'download_metadata.swift')
             files_list.append File.join(get_project_root(), get_project_name(), 'Resources', get_from_env!(key: 'APP_STORE_STRINGS_FILE_NAME'))
           end
 
@@ -45,7 +44,7 @@ def self.localize_project
           Fastlane::Helper::GitHelper.commit(message: 'Update strings for localization', files: strings_files, push: true) || UI.message('No new strings, skipping commit')
         end
 
-        # Call the `Scripts/update-translations.rb` then the `fastlane/download_metadata` Scripts from the host project folder
+        # Call the `Scripts/update-translations.rb` script from the host project folder
         #
         # @env PROJECT_ROOT_FOLDER The path to the git root of the project
         # @env PROJECT_NAME The name of the directory containing the project code (especially containing the `build.gradle` file)
@@ -57,10 +56,6 @@ def self.update_metadata
           Action.sh("cd #{get_project_root()} && ./Scripts/update-translations.rb")
 
           Fastlane::Helper::GitHelper.commit(message: 'Update translations', files: strings_files, push: false)
-
-          Action.sh('cd fastlane && ./download_metadata.swift')
-
-          Fastlane::Helper::GitHelper.commit(message: 'Update metadata translations', files: './fastlane/metadata/', push: true)
         end
 
         def self.strings_files

spec/ios_git_helper_spec.rb

@@ -26,7 +26,7 @@
 
     it 'commits and pushes the app version bump with deliver file and metadata' do
       expect(Fastlane::Helper::GitHelper).to receive(:commit) do |arg|
-        expect_commited_files(files: arg[:files], names: %w[config Deliverfile Resources download_metadata.swift])
+        expect_commited_files(files: arg[:files], names: %w[config Deliverfile Resources])
       end
 
       described_class.commit_version_bump()
@@ -42,7 +42,7 @@
 
     it 'commits and pushes the app version bump with metadata only' do
       expect(Fastlane::Helper::GitHelper).to receive(:commit) do |arg|
-        expect_commited_files(files: arg[:files], names: %w[config Resources download_metadata.swift])
+        expect_commited_files(files: arg[:files], names: %w[config Resources])
       end
 
       described_class.commit_version_bump(include_deliverfile: false)