Validate openai_ask tools parameter

Author: iangmaia

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/openai_ask_action.rb

@@ -47,7 +47,7 @@ def self.run(params)
           return parse_text_response(response)
         end
 
-        UI.user_error!('Parameter `tools` must be a non-empty Array when provided') if tools.empty?
+        validate_tools_array!(tools)
         validate_tools!(tools)
         run_with_tools(
           prompt: prompt,
@@ -157,6 +157,10 @@ def self.validate_max_tool_iterations!(max_tool_iterations)
         UI.user_error!("Parameter `max_tool_iterations` must be >= 1 (got #{max_tool_iterations})") if max_tool_iterations < 1
       end
 
+      def self.validate_tools_array!(tools)
+        UI.user_error!('Parameter `tools` must be a non-empty Array when provided') unless tools.is_a?(Array) && !tools.empty?
+      end
+
       def self.validate_tools!(tools)
         invalid_tools = tools.each_with_index.filter_map do |tool, index|
           type = tool_type(tool)
@@ -402,7 +406,7 @@ def self.available_options
                                        default_value: nil,
                                        type: Array,
                                        verify_block: proc do |value|
-                                         UI.user_error!('Parameter `tools` must be a non-empty Array when provided') if value.empty?
+                                         validate_tools_array!(value)
                                          validate_tools!(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :tool_handlers,

spec/openai_ask_action_spec.rb

@@ -454,7 +454,7 @@ def run_test(prompt_param:, question_param:, expected_prompt:, expected_response
     end
 
     it 'returns a structured error tool result when the handler raises' do
-      expect(UI).not_to receive(:verbose)
+      expect(FastlaneCore::UI).not_to receive(:verbose)
 
       tool_handlers = {
         'check_length' => ->(_args) { raise ArgumentError, 'bad args' }
@@ -475,7 +475,7 @@ def run_test(prompt_param:, question_param:, expected_prompt:, expected_response
           { status: 200, body: second_response }
         )
 
-      expect(UI).to receive(:error).with(
+      expect(FastlaneCore::UI).to receive(:error).with(
         satisfy do |message|
           message.include?("Handler for tool 'check_length' raised ArgumentError") &&
             !message.include?('bad args') &&
@@ -532,7 +532,7 @@ def to_json(*_args)
           { status: 200, body: second_response }
         )
 
-      expect(UI).to receive(:error).with(
+      expect(FastlaneCore::UI).to receive(:error).with(
         satisfy do |message|
           message.include?("Could not serialize tool result for 'check_length': RuntimeError") &&
             !message.include?('cannot serialize')
@@ -578,7 +578,7 @@ def to_json(*_args)
           { status: 200, body: second_response }
         )
 
-      expect(UI).to receive(:error).with(
+      expect(FastlaneCore::UI).to receive(:error).with(
         satisfy do |message|
           message.include?("Invalid JSON arguments for tool 'check_length'") &&
             !message.include?('secret_token=abc123')
@@ -601,8 +601,8 @@ def to_json(*_args)
     end
 
     it 'does not log raw tool arguments even when verbose mode is enabled' do
-      expect(UI).to receive(:error).with(/Raw payload omitted/)
-      expect(UI).not_to receive(:verbose)
+      expect(FastlaneCore::UI).to receive(:error).with(/Raw payload omitted/)
+      expect(FastlaneCore::UI).not_to receive(:verbose)
 
       result = described_class.execute_tool_call(
         {
@@ -623,7 +623,7 @@ def to_json(*_args)
     end
 
     it 'returns a structured error tool result for unsupported returned tool call types' do
-      expect(UI).to receive(:error).with(/Unsupported OpenAI tool call type 'custom'/)
+      expect(FastlaneCore::UI).to receive(:error).with(/Unsupported OpenAI tool call type 'custom'/)
 
       result = described_class.execute_tool_call(
         {
@@ -647,7 +647,7 @@ def to_json(*_args)
     end
 
     it 'returns a clear structured error when a returned function tool call has no name' do
-      expect(UI).to receive(:error).with(/missing a non-empty function.name/)
+      expect(FastlaneCore::UI).to receive(:error).with(/missing a non-empty function.name/)
 
       result = described_class.execute_tool_call(
         {
@@ -711,6 +711,17 @@ def to_json(*_args)
       end.to raise_error(FastlaneCore::Interface::FastlaneError, /tools.*non-empty Array/)
     end
 
+    it 'rejects non-array tools when run directly' do
+      expect do
+        described_class.run(
+          api_token: fake_token,
+          prompt: 'sys',
+          question: 'q',
+          tools: 'not a tools array'
+        )
+      end.to raise_error(FastlaneCore::Interface::FastlaneError, /tools.*non-empty Array/)
+    end
+
     it 'rejects unsupported tool definition types' do
       expect do
         described_class.run(