Remove Fastlane-specific require from gemspec (#373)

Author: mokagio

.rubocop.yml

@@ -9,12 +9,6 @@ AllCops:
 
 ########## Lint / CodeStyle
 
-# This gem is included as part of the `Pluginfile`, which is `required` separately,
-# so makes it hard to keep it ordered with the rest of the gems
-Gemspec/OrderedDependencies:
-  Exclude:
-    - 'fastlane-plugin-wpmreleasetoolkit.gemspec'
-
 # Especially for actions and methods like `self.run(params)` it's common to have the argument unused; but that
 # comes with the parent class API / contract, so we feel it more readable to avoid the _ unused prefix for those.
 Lint/UnusedMethodArgument:

Gemfile

@@ -10,6 +10,3 @@ gem 'webmock', require: false
 gem 'yard'
 
 gem 'rspec-buildkite-analytics', '~> 0.8.1'
-
-plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
-eval_gemfile(plugins_path) if File.exist?(plugins_path)

fastlane-plugin-wpmreleasetoolkit.gemspec

@@ -25,35 +25,35 @@ Gem::Specification.new do |spec|
   # since this would cause a circular dependency
 
   # spec.add_dependency 'your-dependency', '~> 1.0.0'
+  spec.add_dependency 'activesupport', '~> 5'
+  spec.add_dependency 'buildkit', '~> 1.5'
+  spec.add_dependency 'chroma', '0.2.0'
   spec.add_dependency 'diffy', '~> 3.3'
+  spec.add_dependency 'git', '~> 1.3'
+  spec.add_dependency 'jsonlint', '~> 0.3'
   spec.add_dependency 'nokogiri', '~> 1.11' # Needed for AndroidLocalizeHelper
   spec.add_dependency 'octokit', '~> 4.18'
-  spec.add_dependency 'buildkit', '~> 1.5'
+  spec.add_dependency 'parallel', '~> 1.14'
   spec.add_dependency 'plist', '~> 3.1'
-  spec.add_dependency 'git', '~> 1.3'
-  spec.add_dependency 'jsonlint', '~> 0.3'
+  spec.add_dependency 'progress_bar', '~> 1.3'
   spec.add_dependency 'rake', '>= 12.3', '< 14.0'
   spec.add_dependency 'rake-compiler', '~> 1.0'
-  spec.add_dependency 'progress_bar', '~> 1.3'
-  spec.add_dependency 'parallel', '~> 1.14'
-  spec.add_dependency 'chroma', '0.2.0'
-  spec.add_dependency 'activesupport', '~> 5'
   # Some of the upstream code uses `BigDecimal.new` which version 2.0 of the
   # `bigdecimal` gem removed. Until we'll find the time to identify the
   # dependencies and see if we can move them to something compatible with
   # modern `bigdecimal`, let's constrain the gem to a version still supporting
   # `.new` but which warns about it deprecation.
   spec.add_dependency 'bigdecimal', '~> 1.4'
 
-  spec.add_development_dependency 'pry', '~> 0.12.2'
   spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'cocoapods', '~> 1.10'
+  spec.add_development_dependency 'fastlane', '~> 2'
+  spec.add_development_dependency 'pry', '~> 0.12.2'
+  spec.add_development_dependency 'rmagick', '~> 4.1'
   spec.add_development_dependency 'rspec', '~> 3.8'
   spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
   spec.add_development_dependency 'rubocop', '~> 1.0'
-  spec.add_development_dependency 'rubocop-rspec', '2.3.0'
   spec.add_development_dependency 'rubocop-require_tools', '~> 0.1.2'
+  spec.add_development_dependency 'rubocop-rspec', '2.3.0'
   spec.add_development_dependency 'simplecov', '~> 0.16.1'
-  spec.add_development_dependency 'fastlane', '~> 2'
-  spec.add_development_dependency 'rmagick', '~> 4.1'
-  spec.add_development_dependency 'cocoapods', '~> 1.10'
 end