Expect code 201 on success, not 200

Author: AliSoftware

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_send_app_size_metrics.rb

@@ -149,7 +149,7 @@ def self.return_type
       end
 
       def self.return_value
-        'The HTTP return code from the call'
+        'The HTTP return code from the call. Expect a 201 when new metrics were received successfully and entries created in the database'
       end
 
       def self.authors

lib/fastlane/plugin/wpmreleasetoolkit/models/app_size_metrics_payload.rb

@@ -56,7 +56,7 @@ def send_metrics(base_url:, api_token:, use_gzip: true)
         if uri.is_a?(URI::File)
           UI.message("Writing metrics payload to file #{uri.path} (instead of sending it to a server)")
           File.write(uri.path, json_payload)
-          return 200 # To make it easy at call site to check for pseudo-status code 200 even in non-HTTP cases
+          return 201 # To make it easy at call site to check for pseudo-status code 200 even in non-HTTP cases
         end
 
         UI.message("Sending metrics to #{uri}...")

spec/ios_send_app_size_metrics_spec.rb

@@ -27,7 +27,7 @@ def test_app_size_action(fake_ipa_size:, expected_json:, **other_action_args)
       last_received_body = nil
       stub = stub_request(:post, mocked_endpoint).with(headers: expected_headers) do |req|
         last_received_body = req.body
-      end.to_return(status: 200)
+      end.to_return(status: 201)
 
       # Act
       code = run_described_fastlane_action(
@@ -39,7 +39,7 @@ def test_app_size_action(fake_ipa_size:, expected_json:, **other_action_args)
 
       # Asserts
       expect(stub).to have_been_made.once
-      expect(code).to eq(200)
+      expect(code).to eq(201)
       last_received_body_uncompressed = nil
       puts other_action_args.inspect
       if other_action_args[:use_gzip_content_encoding] === false
@@ -148,7 +148,7 @@ def test_app_size_action(fake_ipa_size:, expected_json:, **other_action_args)
         )
 
         # Assert
-        expect(code).to eq(200)
+        expect(code).to eq(201)
         expect(File).to exist(output_path)
         expect(JSON.parse(Zlib.gunzip(File.read(output_path)))).to eq(JSON.parse(expected_json))
       end
@@ -178,7 +178,7 @@ def test_app_size_action(fake_ipa_size:, expected_json:, **other_action_args)
           )
 
         # Assert
-        expect(code).to eq(200)
+        expect(code).to eq(201)
         expect(File).to exist(output_path)
         expect(JSON.parse(File.read(output_path))).to eq(JSON.parse(expected_json))
       end