Merge pull request #391 from wordpress-mobile/fix/milestones-being-compared-as-strings

Fixes milestones being compared as strings

Author: oguzkocer

CHANGELOG.md

@@ -13,6 +13,7 @@ _None_
 - Add `tools:ignore="InconsistentArrays"` to `available_languages.xml` to avoid a linter warning on repos hosting multiple app flavors. [#390]
 
 ### Bug Fixes
+* Fixes milestones being compared as strings instead of integers in `github_helper.get_last_milestone` [#391]
 
 _None_
 

lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

@@ -70,7 +70,7 @@ def self.get_last_milestone(repository)
           else
             begin
               last_vcomps = last_stone[:title].split[0].split('.')
-              last_stone = mile if mile_vcomps[0] > last_vcomps[0] || mile_vcomps[1] > last_vcomps[1]
+              last_stone = mile if Integer(mile_vcomps[0]) > Integer(last_vcomps[0]) || Integer(mile_vcomps[1]) > Integer(last_vcomps[1])
             rescue StandardError
               puts 'Found invalid milestone'
             end

spec/github_helper_spec.rb

@@ -92,6 +92,30 @@
     end
   end
 
+  describe 'get_last_milestone' do
+    let(:test_repo) { 'repo-test/project-test' }
+    let(:last_stone) { mock_milestone('10.0') }
+    let(:client) do
+      instance_double(
+        Octokit::Client,
+        list_milestones: ['9.8 ❄️', '9.9'].map { |title| mock_milestone(title) }.append(last_stone)
+      )
+    end
+
+    before do
+      allow(described_class).to receive(:github_client).and_return(client)
+    end
+
+    it 'returns correct milestone' do
+      expect(client).to receive(:list_milestones)
+      expect(described_class.get_last_milestone(repository: test_repo)).to eq(last_stone)
+    end
+
+    def mock_milestone(title)
+      { title: title }
+    end
+  end
+
   describe 'comment_on_pr' do
     let(:client) do
       instance_double(