Merge pull request #471 from wordpress-mobile/deprecate/ios_final_tag_and_ios_clear_intermediate_tags

Deprecate ios_final_tag and ios_clear_intermediate_tags

Author: oguzkocer

CHANGELOG.md

@@ -38,6 +38,7 @@ _None_
 - Adds `ignore_pipeline_branch_filters=true` parameter to the API call triggering a Buildkite build [#468]
 - Replace all instances of `is_string` with `type` [#469]
 - Use `git_branch_name_using_HEAD` instead of `git_branch` so that the return value is not modified by environment variables. This has no impact to our current release flow, that's why it's not in "Breaking changes" section. [#463]
+- Deprecate `ios_clear_intermediate_tags` & `ios_final_tag` actions. [#471]
 
 ## 7.0.0
 

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_clear_intermediate_tags.rb

@@ -2,6 +2,8 @@ module Fastlane
   module Actions
     class IosClearIntermediateTagsAction < Action
       def self.run(params)
+        return unless UI.confirm("#{deprecated_notes} Would you like to continue with the action?")
+
         UI.message("Deleting tags for version: #{params[:version]}")
 
         require_relative '../../helper/git_helper'
@@ -26,11 +28,11 @@ def self.run(params)
       #####################################################
 
       def self.description
-        'Cleans all the intermediate tags for the given version'
+        '(DEPRECATED) Cleans all the intermediate tags for the given version'
       end
 
       def self.details
-        'Cleans all the intermediate tags for the given version'
+        '(DEPRECATED) Cleans all the intermediate tags for the given version'
       end
 
       def self.available_options
@@ -48,6 +50,16 @@ def self.output
       def self.return_value
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        "This action is deprecated as we don't believe it's currently in use in our projects.
+        However, just to be sure that it's not in use, we decided to deprecate it first. If you
+        believe that this is a mistake, please let us know on Slack."
+      end
+
       def self.authors
         ['Automattic']
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_final_tag.rb

@@ -2,6 +2,8 @@ module Fastlane
   module Actions
     class IosFinalTagAction < Action
       def self.run(params)
+        return unless UI.confirm("#{deprecated_notes} Would you like to continue with the action?")
+
         require_relative '../../helper/ios/ios_git_helper'
         require_relative '../../helper/ios/ios_version_helper'
         version = Fastlane::Helper::Ios::VersionHelper.get_public_version
@@ -18,11 +20,11 @@ def self.run(params)
       #####################################################
 
       def self.description
-        'Finalize a relasae'
+        '(DEPRECATED) Finalize a relasae'
       end
 
       def self.details
-        'Removes the temp tags and pushes the final one'
+        '(DEPRECATED) Removes the temp tags and pushes the final one'
       end
 
       def self.available_options
@@ -40,6 +42,16 @@ def self.output
       def self.return_value
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        "This action is deprecated as we don't believe it's currently in use in our projects.
+        However, just to be sure that it's not in use, we decided to deprecate it first. If you
+        believe that this is a mistake, please let us know on Slack."
+      end
+
       def self.authors
         ['Automattic']
       end