Skip to content

Commit f486a8e

Browse files
AliSoftwareAliSoftware
committed
Fix rubocop violations
1 parent 5dd4016 commit f486a8e

2 files changed

Lines changed: 60 additions & 61 deletions

File tree

‎lib/fastlane/plugin/wpmreleasetoolkit/models/locales.rb‎

Lines changed: 55 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -6,64 +6,63 @@ def self.[](code)
66
end
77

88
class Locales
9-
109
###################
1110
## Constants
1211
ALL_KNOWN_LOCALES = [
13-
Locale.new(glotpress: "ar", android: "ar", google_play: "ar" ),
14-
Locale.new(glotpress: "de", android: "de", google_play: "de-DE"),
15-
Locale.new(glotpress: "en-gb", android: "en-rGB", google_play: "en-US"),
16-
Locale.new(glotpress: "es", android: "es", google_play: "es-ES"),
17-
Locale.new(glotpress: "fr-ca", android: "fr-rCA", google_play: "fr-CA"),
18-
Locale.new(glotpress: "fr", android: "fr", google_play: "fr-FR"),
19-
Locale.new(glotpress: "he", android: "he", google_play: "iw-IL"),
20-
Locale.new(glotpress: "id", android: "id", google_play: "id" ),
21-
Locale.new(glotpress: "it", android: "it", google_play: "it-IT"),
22-
Locale.new(glotpress: "ja", android: "ja", google_play: "ja-JP"),
23-
Locale.new(glotpress: "ko", android: "ko", google_play: "ko-KR"),
24-
Locale.new(glotpress: "nl", android: "nl", google_play: "nl-NL"),
25-
Locale.new(glotpress: "pl", android: "pl", google_play: "pl-PL"),
26-
Locale.new(glotpress: "pt-br", android: "pt-rBR", google_play: "pt-BR"),
27-
Locale.new(glotpress: "ru", android: "ru", google_play: "ru-RU"),
28-
Locale.new(glotpress: "sr", android: "sr", google_play: "sr" ),
29-
Locale.new(glotpress: "sv", android: "sv", google_play: "sv-SE"),
30-
Locale.new(glotpress: "th", android: "th", google_play: "th" ),
31-
Locale.new(glotpress: "tr", android: "tr", google_play: "tr-TR"),
32-
Locale.new(glotpress: "vi", android: "vi", google_play: "vi" ),
33-
Locale.new(glotpress: "zh-cn", android: "zh-rCN", google_play: "zh-CN"),
34-
Locale.new(glotpress: "zh-tw", android: "zh-rTW", google_play: "zh-TW"),
35-
Locale.new(glotpress: "az", android: "az"),
36-
Locale.new(glotpress: "el", android: "el"),
37-
Locale.new(glotpress: "es-mx", android: "es-rMX"),
38-
Locale.new(glotpress: "es-cl", android: "es-rCL"),
39-
Locale.new(glotpress: "gd", android: "gd"),
40-
Locale.new(glotpress: "hi", android: "hi"),
41-
Locale.new(glotpress: "hu", android: "hu"),
42-
Locale.new(glotpress: "nb", android: "nb"),
43-
Locale.new(glotpress: "pl", android: "pl"),
44-
Locale.new(glotpress: "th", android: "th"),
45-
Locale.new(glotpress: "uz", android: "uz"),
46-
Locale.new(glotpress: "zh-tw", android: "zh-rHK"),
47-
Locale.new(glotpress: "eu", android: "eu"),
48-
Locale.new(glotpress: "ro", android: "ro"),
49-
Locale.new(glotpress: "mk", android: "mk"),
50-
Locale.new(glotpress: "en-au", android: "en-rAU"),
51-
Locale.new(glotpress: "sr", android: "sr"),
52-
Locale.new(glotpress: "sk", android: "sk"),
53-
Locale.new(glotpress: "cy", android: "cy"),
54-
Locale.new(glotpress: "da", android: "da"),
55-
Locale.new(glotpress: "bg", android: "bg"),
56-
Locale.new(glotpress: "sq", android: "sq"),
57-
Locale.new(glotpress: "hr", android: "hr"),
58-
Locale.new(glotpress: "cs", android: "cs"),
59-
Locale.new(glotpress: "pt-br", android: "pt-rBR"),
60-
Locale.new(glotpress: "en-ca", android: "en-rCA"),
61-
Locale.new(glotpress: "ms", android: "ms"),
62-
Locale.new(glotpress: "es-ve", android: "es-rVE"),
63-
Locale.new(glotpress: "gl", android: "gl"),
64-
Locale.new(glotpress: "is", android: "is"),
65-
Locale.new(glotpress: "es-co", android: "es-rCO"),
66-
Locale.new(glotpress: "kmr", android: "kmr")
12+
Locale.new(glotpress: 'ar', android: 'ar', google_play: 'ar'),
13+
Locale.new(glotpress: 'de', android: 'de', google_play: 'de-DE'),
14+
Locale.new(glotpress: 'en-gb', android: 'en-rGB', google_play: 'en-US'),
15+
Locale.new(glotpress: 'es', android: 'es', google_play: 'es-ES'),
16+
Locale.new(glotpress: 'fr-ca', android: 'fr-rCA', google_play: 'fr-CA'),
17+
Locale.new(glotpress: 'fr', android: 'fr', google_play: 'fr-FR'),
18+
Locale.new(glotpress: 'he', android: 'he', google_play: 'iw-IL'),
19+
Locale.new(glotpress: 'id', android: 'id', google_play: 'id'),
20+
Locale.new(glotpress: 'it', android: 'it', google_play: 'it-IT'),
21+
Locale.new(glotpress: 'ja', android: 'ja', google_play: 'ja-JP'),
22+
Locale.new(glotpress: 'ko', android: 'ko', google_play: 'ko-KR'),
23+
Locale.new(glotpress: 'nl', android: 'nl', google_play: 'nl-NL'),
24+
Locale.new(glotpress: 'pl', android: 'pl', google_play: 'pl-PL'),
25+
Locale.new(glotpress: 'pt-br', android: 'pt-rBR', google_play: 'pt-BR'),
26+
Locale.new(glotpress: 'ru', android: 'ru', google_play: 'ru-RU'),
27+
Locale.new(glotpress: 'sr', android: 'sr', google_play: 'sr'),
28+
Locale.new(glotpress: 'sv', android: 'sv', google_play: 'sv-SE'),
29+
Locale.new(glotpress: 'th', android: 'th', google_play: 'th'),
30+
Locale.new(glotpress: 'tr', android: 'tr', google_play: 'tr-TR'),
31+
Locale.new(glotpress: 'vi', android: 'vi', google_play: 'vi'),
32+
Locale.new(glotpress: 'zh-cn', android: 'zh-rCN', google_play: 'zh-CN'),
33+
Locale.new(glotpress: 'zh-tw', android: 'zh-rTW', google_play: 'zh-TW'),
34+
Locale.new(glotpress: 'az', android: 'az'),
35+
Locale.new(glotpress: 'el', android: 'el'),
36+
Locale.new(glotpress: 'es-mx', android: 'es-rMX'),
37+
Locale.new(glotpress: 'es-cl', android: 'es-rCL'),
38+
Locale.new(glotpress: 'gd', android: 'gd'),
39+
Locale.new(glotpress: 'hi', android: 'hi'),
40+
Locale.new(glotpress: 'hu', android: 'hu'),
41+
Locale.new(glotpress: 'nb', android: 'nb'),
42+
Locale.new(glotpress: 'pl', android: 'pl'),
43+
Locale.new(glotpress: 'th', android: 'th'),
44+
Locale.new(glotpress: 'uz', android: 'uz'),
45+
Locale.new(glotpress: 'zh-tw', android: 'zh-rHK'),
46+
Locale.new(glotpress: 'eu', android: 'eu'),
47+
Locale.new(glotpress: 'ro', android: 'ro'),
48+
Locale.new(glotpress: 'mk', android: 'mk'),
49+
Locale.new(glotpress: 'en-au', android: 'en-rAU'),
50+
Locale.new(glotpress: 'sr', android: 'sr'),
51+
Locale.new(glotpress: 'sk', android: 'sk'),
52+
Locale.new(glotpress: 'cy', android: 'cy'),
53+
Locale.new(glotpress: 'da', android: 'da'),
54+
Locale.new(glotpress: 'bg', android: 'bg'),
55+
Locale.new(glotpress: 'sq', android: 'sq'),
56+
Locale.new(glotpress: 'hr', android: 'hr'),
57+
Locale.new(glotpress: 'cs', android: 'cs'),
58+
Locale.new(glotpress: 'pt-br', android: 'pt-rBR'),
59+
Locale.new(glotpress: 'en-ca', android: 'en-rCA'),
60+
Locale.new(glotpress: 'ms', android: 'ms'),
61+
Locale.new(glotpress: 'es-ve', android: 'es-rVE'),
62+
Locale.new(glotpress: 'gl', android: 'gl'),
63+
Locale.new(glotpress: 'is', android: 'is'),
64+
Locale.new(glotpress: 'es-co', android: 'es-rCO'),
65+
Locale.new(glotpress: 'kmr', android: 'kmr'),
6766
].freeze
6867

6968
MAG16_GP_CODES = %w[ar de es fr he id it ja ko nl pt-br ru sv tr zh-cn zh-tw].freeze
@@ -72,7 +71,6 @@ class Locales
7271
## Static Methods
7372

7473
class << self
75-
7674
# @return [Array<Locale>] Array of all the known locales
7775
#
7876
def all
@@ -117,6 +115,7 @@ def search(key, code_or_list)
117115
code_or_list.map { |code| search(key, code) }
118116
else # String
119117
raise 'The locale code should not contain spaces. Did you accidentally use `%[]` instead of `%w[]` at call site?' if code_or_list.include?(' ')
118+
120119
ALL_KNOWN_LOCALES.find { |locale| locale.send(key) == code_or_list } || not_found(code_or_list, key)
121120
end
122121
end

‎spec/locales_spec.rb‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
end
99

1010
it 'raises if no locale was found for a given code' do
11-
expect {
11+
expect do
1212
Fastlane::Locale['invalidcode']
13-
}.to raise_error(RuntimeError, "Unknown locale for glotpress code 'invalidcode'")
13+
end.to raise_error(RuntimeError, "Unknown locale for glotpress code 'invalidcode'")
1414
end
1515
end
1616

@@ -37,9 +37,9 @@
3737
end
3838

3939
it 'raises if one of the locale codes passed was not found' do
40-
expect {
40+
expect do
4141
Fastlane::Locales.send(method_sym, [fr_code, 'invalidcode', 'pt-br'])
42-
}.to raise_error(RuntimeError, "Unknown locale for #{key} code 'invalidcode'")
42+
end.to raise_error(RuntimeError, "Unknown locale for #{key} code 'invalidcode'")
4343
end
4444
end
4545

@@ -95,7 +95,7 @@
9595
mag16_except_pt = Fastlane::Locales.mag16 - Fastlane::Locales['pt-br']
9696
expect(mag16_except_pt.count).to equal(15)
9797
expect(mag16_except_pt.find { |l| l.glotpress == 'pt-br' }).to be_nil
98-
expect(mag16_except_pt.find { |l| l.glotpress == 'fr' }).to_not be_nil
98+
expect(mag16_except_pt.find { |l| l.glotpress == 'fr' }).not_to be_nil
9999
end
100100

101101
it 'can convert a Locale to a hash' do

0 commit comments

Comments
 (0)