Validate tool iterations only with tools

Author: iangmaia

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/openai_ask_action.rb

@@ -33,7 +33,6 @@ def self.run(params)
         # callers can register handlers with either string or symbol keys without surprises.
         tool_handlers = (params[:tool_handlers] || {}).transform_keys(&:to_s)
         max_tool_iterations = params[:max_tool_iterations] || DEFAULT_MAX_TOOL_ITERATIONS
-        validate_max_tool_iterations!(max_tool_iterations)
 
         headers = {
           'Content-Type': 'application/json',
@@ -48,6 +47,7 @@ def self.run(params)
         end
 
         validate_tools_array!(tools)
+        validate_max_tool_iterations!(max_tool_iterations)
         validate_tools!(tools)
         run_with_tools(
           prompt: prompt,

spec/openai_ask_action_spec.rb

@@ -134,6 +134,24 @@ def run_test(prompt_param:, question_param:, expected_prompt:, expected_response
     expect(JSON.parse(expected_req_body)['model']).to eq('gpt-4o-mini')
   end
 
+  it 'ignores max_tool_iterations on the single-shot path' do
+    expected_req_body = described_class.request_body(prompt: 'sys', question: 'q')
+
+    stub = stub_request(:post, endpoint)
+           .with(body: expected_req_body)
+           .to_return(status: 200, body: stubbed_response('Hi.'))
+
+    result = described_class.run(
+      api_token: fake_token,
+      prompt: 'sys',
+      question: 'q',
+      max_tool_iterations: 'not used without tools'
+    )
+
+    expect(result).to eq('Hi.')
+    expect(stub).to have_been_requested
+  end
+
   it 'uses max_completion_tokens instead of deprecated max_tokens' do
     body = JSON.parse(described_class.request_body(prompt: 'sys', question: 'q'))