Refactor new milestone creation to allow for parametrized duration

Author: oguzkocer

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_new_milestone_action.rb

@@ -12,10 +12,11 @@ def self.run(params)
         last_stone = Fastlane::Helper::GithubHelper.get_last_milestone(repository)
         UI.message("Last detected milestone: #{last_stone[:title]} due on #{last_stone[:due_on]}.")
         milestone_duedate = last_stone[:due_on]
-        newmilestone_duedate = (milestone_duedate.to_datetime.next_day(14).to_time).utc
+        newmilestone_duration = params[:milestone_duration]
+        newmilestone_duedate = (milestone_duedate.to_datetime.next_day(newmilestone_duration).to_time).utc
         newmilestone_number = Fastlane::Helper::Ios::VersionHelper.calc_next_release_version(last_stone[:title])
         UI.message("Next milestone: #{newmilestone_number} due on #{newmilestone_duedate}.")
-        Fastlane::Helper::GithubHelper.create_milestone(repository, newmilestone_number, newmilestone_duedate, params[:need_appstore_submission])
+        Fastlane::Helper::GithubHelper.create_milestone(repository, newmilestone_number, newmilestone_duedate, newmilestone_duration, params[:need_appstore_submission])
       end
 
       def self.description
@@ -48,6 +49,12 @@ def self.available_options
                                        optional: true,
                                        is_string: false,
                                        default_value: false),
+          FastlaneCore::ConfigItem.new(key: :milestone_duration,
+                                       env_name: 'GHHELPER_MILESTONE_DURATION',
+                                       description: 'Milestone duration in number of days',
+                                       optional: true,
+                                       is_string: false,
+                                       default_value: 14),
         ]
       end
 

lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

@@ -80,9 +80,13 @@ def self.get_last_milestone(repository)
         last_stone
       end
 
-      def self.create_milestone(repository, newmilestone_number, newmilestone_duedate, need_submission)
-        submission_date = need_submission ? newmilestone_duedate.to_datetime.next_day(11) : newmilestone_duedate.to_datetime.next_day(14)
-        release_date = newmilestone_duedate.to_datetime.next_day(14)
+      def self.create_milestone(repository, newmilestone_number, newmilestone_duedate, newmilestone_duration, need_submission)
+        # If there is a review process, we want to submit the binary 3 days before its release
+        #
+        # Using 3 days is mostly for historical reasons where we release the apps on Monday and submit them on Friday.
+        days_until_submission = need_submission ? (newmilestone_duration - 3) : newmilestone_duration
+        submission_date = newmilestone_duedate.to_datetime.next_day(days_until_submission)
+        release_date = newmilestone_duedate.to_datetime.next_day(newmilestone_duration)
         comment = "Code freeze: #{newmilestone_duedate.to_datetime.strftime('%B %d, %Y')} App Store submission: #{submission_date.strftime('%B %d, %Y')} Release: #{release_date.strftime('%B %d, %Y')}"
 
         options = {}