Clarify release lookup error handling - #755
Merged
Merged
Conversation
AliSoftware
approved these changes
Jul 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the contract around GitHub release discovery by ensuring that only “missing release” (404) errors are swallowed during the direct release-by-tag fallback, while unexpected API failures propagate to callers. It fits into the GithubHelper helper layer that encapsulates Octokit interactions used by Fastlane actions.
Changes:
- Adds an RSpec regression test to verify
Octokit::TooManyRequestsraised during direct tag lookup is not hidden. - Clarifies (via inline comment) that only
Octokit::NotFoundshould be converted tonilin the fallback lookup path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/github_helper_spec.rb | Adds a regression spec asserting unexpected Octokit errors aren’t swallowed during the fallback release lookup. |
| lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb | Documents the intent of rescuing only Octokit::NotFound in the tag-based fallback. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
iangmaia
enabled auto-merge
July 13, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small regression test to confirm only missing releases are swallowed during the direct release lookup fallback.