chore(workspace): update pnpm workspace configuration and add patched dependencies#63
Conversation
… dependencies - Updated `pnpm-workspace.yaml` to include `edgedriver` and `geckodriver` in the `onlyBuiltDependencies` section. - Added a new `patchedDependencies` section to include a patch for `logrocket@12.0.0` located at `patches/logrocket@12.0.0.patch`. feat(web): update TypeScript and add native preview dependency - In `samples/web/package.json`, added `@typescript/native-preview` with version `7.0.0-dev.20260227.1`. - Removed the existing `typescript` dependency version `5.9.3` to allow for potential upgrades or changes in the TypeScript ecosystem. fix(logrocket): update type declaration from module to namespace - Created a patch file `patches/logrocket@12.0.0.patch` to modify the type declaration in `logrocket` from a module to a namespace in `dist/types.d.ts`, ensuring compatibility with TypeScript's declaration merging.
commit: |
There was a problem hiding this comment.
Pull request overview
This pull request introduces experimental TypeScript native preview tooling and makes workspace configuration improvements. It adds the @typescript/native-preview package across the workspace while removing the standard typescript package dependency, configures browser driver packages for proper installation, and applies a type declaration patch to logrocket for TypeScript compatibility.
Changes:
- Added
@typescript/native-preview@7.0.0-dev.20260227.1as a devDependency across root, samples/web, and packages/logging - Removed
typescript@5.9.3from explicit devDependencies (though still resolved via optional dependencies) - Added
edgedriverandgeckodrivertoonlyBuiltDependenciesin pnpm workspace configuration - Created a patch for
logrocket@12.0.0changing type declaration from module to namespace for TypeScript compatibility
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added browser drivers to onlyBuiltDependencies and configured logrocket patch |
| package.json | Added native TypeScript preview and removed standard TypeScript package |
| packages/logging/package.json | Added native TypeScript preview and removed standard TypeScript package |
| samples/web/package.json | Added native TypeScript preview and removed standard TypeScript package |
| patches/logrocket@12.0.0.patch | Created patch to change module declaration to namespace in logrocket types |
| pnpm-lock.yaml | Updated dependency resolutions reflecting all package changes |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@workleap/rsbuild-configs": "3.2.2", | ||
| "@workleap/typescript-configs": "3.0.7", | ||
| "browserslist": "4.28.1", | ||
| "eslint": "9.39.2", |
There was a problem hiding this comment.
The typescript package has been removed from devDependencies, but TypeScript 5.9.3 is still being used throughout the project via optional dependency resolution in the lockfile. The @typescript/native-preview package provides the TypeScript compiler binary, but it's unclear if this is a complete replacement or if both should coexist. Consider documenting this architectural decision, as it may confuse contributors who expect to see the standard typescript package. Additionally, verify that all tooling (IDE support, build tools, linters) works correctly with only the native preview version.
| "eslint": "9.39.2", | |
| "eslint": "9.39.2", | |
| "typescript": "5.9.3", |
| "turbo": "2.8.3", | ||
| "typescript": "5.9.3", | ||
| "typescript-eslint": "8.55.0" | ||
| }, |
There was a problem hiding this comment.
The typescript package has been removed from devDependencies, but TypeScript 5.9.3 is still being resolved throughout the project via optional dependency resolution in the lockfile. While @typescript/native-preview provides the TypeScript compiler binary, the coexistence of both approaches (native preview explicitly declared, TypeScript 5.9.3 implicitly resolved) may lead to confusion. Consider documenting this architectural decision in the PR description or a README to clarify the intended TypeScript tooling strategy.
| }, | |
| }, | |
| "typescriptToolingStrategy": "The TypeScript compiler is provided by @typescript/native-preview. Any typescript version (e.g., 5.9.3) present only via optional dependency resolution in the lockfile is incidental and is not intended to be used directly as a devDependency.", |
Patrick Lafrance (patricklafrance)
merged commit c726cc1
into
main
Patrick Lafrance (patricklafrance)
deleted the
chore/move-to-ts-native-preview
branch
pnpm-workspace.yamlto includeedgedriverandgeckodriverin theonlyBuiltDependenciessection.patchedDependenciessection to include a patch forlogrocket@12.0.0located atpatches/logrocket@12.0.0.patch.feat(web): update TypeScript and add native preview dependency
samples/web/package.json, added@typescript/native-previewwith version7.0.0-dev.20260227.1.typescriptdependency version5.9.3to allow for potential upgrades or changes in the TypeScript ecosystem.fix(logrocket): update type declaration from module to namespace
patches/logrocket@12.0.0.patchto modify the type declaration inlogrocketfrom a module to a namespace indist/types.d.ts, ensuring compatibility with TypeScript's declaration merging.