Skip to content

chore(turbo.json): add transit task dependency to eslint, typecheck, and test tasks#65

Merged
Patrick Lafrance (patricklafrance) merged 1 commit into
mainfrom
chore/fix-2026-03-01-audit
Mar 2, 2026
Merged

chore(turbo.json): add transit task dependency to eslint, typecheck, and test tasks#65
Patrick Lafrance (patricklafrance) merged 1 commit into
mainfrom
chore/fix-2026-03-01-audit

Conversation

@patricklafrance
Copy link
Copy Markdown
Member

Fix #64

Copilot AI review requested due to automatic review settings March 2, 2026 17:06
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 2, 2026

Open in StackBlitz

pnpm add https://pkg.pr.new/workleap/wl-logging/@workleap/logging@65

commit: 963bf39

@patricklafrance Patrick Lafrance (patricklafrance) merged commit fca489b into main Mar 2, 2026
9 of 10 checks passed
@patricklafrance Patrick Lafrance (patricklafrance) deleted the chore/fix-2026-03-01-audit branch March 2, 2026 17:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Turborepo “transit” task to ensure eslint, typecheck, and test cache keys properly account for changes in dependency packages (addressing the stale-cache audit finding in Issue #64).

Changes:

  • Introduces a transit task that depends on ^transit to propagate dependency changes into downstream task hashing.
  • Updates eslint, typecheck, and test tasks to dependsOn: ["transit"] to fix dependency-aware cache invalidation while preserving parallelism.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread turbo.json
Comment on lines +6 to +7
"dependsOn": ["^transit"],
"outputs": []
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transit is intended as a no-op dependency edge, but setting outputs: [] makes it a cacheable task and can create (empty) local/remote cache entries with little benefit. Consider omitting outputs (like //#syncpack) or explicitly setting cache: false so transit only affects dependency hashing without adding cache churn.

Suggested change
"dependsOn": ["^transit"],
"outputs": []
"dependsOn": ["^transit"]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit: monorepo audit findings — 2026-03-01

2 participants