chore: Improve agent skill with the new version of skill-creator#68
Merged
Conversation
…ration details docs(api.md): enhance API reference with detailed logger usage and factory function docs(patterns.md): improve common patterns documentation with error logging and scoping examples chore(package.json): remove unnecessary test flag from vitest command
Copilot started reviewing on behalf of
Patrick Lafrance (patricklafrance)
March 6, 2026 19:56
View session
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Workleap logging agent-skill documentation to better reflect recommended usage patterns (scopes, error context, LogRocket integration) and adjusts the logging package’s Vitest command.
Changes:
- Remove
--passWithNoTestsfrom@workleap/logging’spnpm testscript. - Expand/clarify logging guidance in the agent skill docs (env detection note, error logging context, scoping, PR checklist).
- Rework API reference examples for
CompositeLogger/createCompositeLogger.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/logging/package.json | Updates the Vitest test script invocation. |
| agent-skills/workleap-logging/references/patterns.md | Improves recommended logging patterns and PR review checklist; streamlines LogRocket guidance. |
| agent-skills/workleap-logging/references/api.md | Expands API reference and examples, including createCompositeLogger. |
| agent-skills/workleap-logging/SKILL.md | Updates the skill scope and adds clarifying guidance around scopes, chaining, and references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.