chore: add @types/node dependency to multiple packages#180
Conversation
Patrick Lafrance (patricklafrance)
requested a review
from a team
as a code owner
@workleap/common-room
@workleap-telemetry/core
@workleap/honeycomb
@workleap/logrocket
@workleap/mixpanel
@workleap/telemetry
commit: |
Patrick Lafrance (patricklafrance)
merged commit 7ecae97
into
main
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit @types/node devDependency to several workspace packages and samples to ensure Node typings are available during TypeScript typechecking/build tooling, and updates the pnpm lockfile accordingly.
Changes:
- Add
@types/node@25.5.0todevDependenciesacross multiple packages and sample apps. - Update
pnpm-lock.yamlto include the new importer entries/resolution for@types/node.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/honeycomb/proxy/app/package.json | Adds @types/node to the sample app devDependencies. |
| samples/honeycomb/api-key/app/package.json | Adds @types/node to the sample app devDependencies. |
| samples/all-platforms/app/package.json | Adds @types/node to the sample app devDependencies. |
| packages/telemetry/package.json | Adds @types/node to package devDependencies. |
| packages/mixpanel/package.json | Adds @types/node to package devDependencies. |
| packages/logrocket/package.json | Adds @types/node to package devDependencies. |
| packages/honeycomb/package.json | Adds @types/node to package devDependencies. |
| packages/core/package.json | Adds @types/node to package devDependencies. |
| packages/common-room/package.json | Adds @types/node to package devDependencies. |
| pnpm-lock.yaml | Updates lockfile importers to include @types/node@25.5.0. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@eslint/js": "9.39.2", | ||
| "@rsbuild/core": "1.7.5", | ||
| "@rslib/core": "0.20.2", | ||
| "@types/node": "25.5.0", |
There was a problem hiding this comment.
This package declares engines.node as ">=21.1.0" (see bottom of this file), but the added @types/node is pinned to 25.5.0. That mismatch can let TypeScript typecheck Node 25-only APIs even though the package claims compatibility with Node 21+, which can lead to runtime incompatibilities. Consider either aligning @types/node to the minimum supported Node major (or a compatible range), or bumping the engines.node requirement to match the typings being used.
| "@types/node": "25.5.0", | |
| "@types/node": "^21.1.0", |
| "@eslint/js": "9.39.2", | ||
| "@rsbuild/core": "1.7.5", | ||
| "@rslib/core": "0.20.2", | ||
| "@types/node": "25.5.0", |
There was a problem hiding this comment.
This package declares engines.node as ">=21.1.0" (see bottom of this file), but the added @types/node is pinned to 25.5.0. That mismatch can let TypeScript typecheck Node 25-only APIs even though the package claims compatibility with Node 21+, which can lead to runtime incompatibilities. Consider either aligning @types/node to the minimum supported Node major (or a compatible range), or bumping the engines.node requirement to match the typings being used.
| "@types/node": "25.5.0", | |
| "@types/node": "^21.1.0", |
No description provided.