Skip to content

chore: add @types/node dependency to multiple packages #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patrick Lafrance (patricklafrance) merged 1 commit into from
Apr 1, 2026
Merged

chore: add @types/node dependency to multiple packages #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/common-room/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
"@eslint/js": "9.39.2",
"@rsbuild/core": "1.7.5",
"@rslib/core": "0.20.2",
"@types/node": "25.5.0",
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package declares engines.node as ">=21.1.0" (see bottom of this file), but the added @types/node is pinned to 25.5.0. That mismatch can let TypeScript typecheck Node 25-only APIs even though the package claims compatibility with Node 21+, which can lead to runtime incompatibilities. Consider either aligning @types/node to the minimum supported Node major (or a compatible range), or bumping the engines.node requirement to match the typings being used.

Suggested change
"@types/node": "25.5.0",
"@types/node": "^21.1.0",

Copilot uses AI. Check for mistakes.
"@types/react": "19.2.14",
"@typescript-eslint/parser": "8.58.0",
"@typescript/native-preview": "7.0.0-dev.20260331.1",
Expand Down
1 change: 1 addition & 0 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"@rsbuild/core": "1.7.5",
"@rslib/core": "0.20.2",
"@types/js-cookie": "3.0.6",
"@types/node": "25.5.0",
"@typescript-eslint/parser": "8.58.0",
"@typescript/native-preview": "7.0.0-dev.20260331.1",
"@workleap/eslint-configs": "1.1.15",
Expand Down
1 change: 1 addition & 0 deletions packages/honeycomb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
"@eslint/js": "9.39.2",
"@rsbuild/core": "1.7.5",
"@rslib/core": "0.20.2",
"@types/node": "25.5.0",
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package declares engines.node as ">=21.1.0" (see bottom of this file), but the added @types/node is pinned to 25.5.0. That mismatch can let TypeScript typecheck Node 25-only APIs even though the package claims compatibility with Node 21+, which can lead to runtime incompatibilities. Consider either aligning @types/node to the minimum supported Node major (or a compatible range), or bumping the engines.node requirement to match the typings being used.

Suggested change
"@types/node": "25.5.0",
"@types/node": "^21.1.0",

Copilot uses AI. Check for mistakes.
"@types/react": "19.2.14",
"@typescript-eslint/parser": "8.58.0",
"@typescript/native-preview": "7.0.0-dev.20260331.1",
Expand Down
1 change: 1 addition & 0 deletions packages/logrocket/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"@eslint/js": "9.39.2",
"@rsbuild/core": "1.7.5",
"@rslib/core": "0.20.2",
"@types/node": "25.5.0",
"@types/react": "19.2.14",
"@typescript-eslint/parser": "8.58.0",
"@typescript/native-preview": "7.0.0-dev.20260331.1",
Expand Down
1 change: 1 addition & 0 deletions packages/mixpanel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"@eslint/js": "9.39.2",
"@rsbuild/core": "1.7.5",
"@rslib/core": "0.20.2",
"@types/node": "25.5.0",
"@types/react": "19.2.14",
"@typescript-eslint/parser": "8.58.0",
"@typescript/native-preview": "7.0.0-dev.20260331.1",
Expand Down
1 change: 1 addition & 0 deletions packages/telemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
"@rsbuild/core": "1.7.5",
"@rslib/core": "0.20.2",
"@types/js-cookie": "3.0.6",
"@types/node": "25.5.0",
"@types/react": "19.2.14",
"@typescript-eslint/parser": "8.58.0",
"@typescript/native-preview": "7.0.0-dev.20260331.1",
Expand Down
27 changes: 27 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions samples/all-platforms/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"@eslint/js": "9.39.2",
"@rsbuild/core": "1.7.5",
"@rspack/core": "1.7.11",
"@types/node": "25.5.0",
"@types/react": "19.2.14",
"@types/react-dom": "19.2.3",
"@typescript-eslint/parser": "8.58.0",
Expand Down
1 change: 1 addition & 0 deletions samples/honeycomb/api-key/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"@eslint/js": "9.39.2",
"@rsbuild/core": "1.7.5",
"@rspack/core": "1.7.11",
"@types/node": "25.5.0",
"@types/react": "19.2.14",
"@types/react-dom": "19.2.3",
"@typescript-eslint/parser": "8.58.0",
Expand Down
1 change: 1 addition & 0 deletions samples/honeycomb/proxy/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"@eslint/js": "9.39.2",
"@rsbuild/core": "1.7.5",
"@rspack/core": "1.7.11",
"@types/node": "25.5.0",
"@types/react": "19.2.14",
"@types/react-dom": "19.2.3",
"@typescript-eslint/parser": "8.58.0",
Expand Down
Loading