Skip to content

Commit c71d75e

Browse files
Copilotalexanmtzgithub-advanced-security[bot]
authored
Refactor tests to use factory pattern instead of direct model instantiation (#1364)
* Initial plan * Create missing factories and update helpers to use them Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Add PaymentRequest factories and refactor all test files to use factories Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Complete refactoring: add PaymentRequestBalanceTransaction factory and fix remaining test files Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Fix AssignFactory to support include options for backward compatibility Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Add comprehensive documentation for test factories Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Fix import paths in findUnclaimedBounties.test.ts to use centralized factory index Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Fix payment-requests test: explicitly set amount to null for custom_amount scenario Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Fix UserFactory to generate unique emails and usernames to avoid validation errors Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Make all factory IDs unique to prevent constraint violations Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * Potential fix for code scanning alert no. 278: Insecure randomness Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Fix TransferFactory to use correct Transfer model fields (value instead of amount) Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> * fixing duplicate issue on test issue factory --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexanmtz <88840+alexanmtz@users.noreply.github.com> Co-authored-by: Alexandre Magno <alexanmtz@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
1 parent ff8f981 commit c71d75e

36 files changed

Lines changed: 605 additions & 168 deletions

‎test/api/task-solution/taskSolution.test.ts‎

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import api from '../../../src/server'
44
import nock from 'nock'
55
import Models from '../../../src/models'
66
import { registerAndLogin, createTask, truncateModels } from '../../helpers'
7+
import { TaskFactory, OrderFactory, AssignFactory } from '../../factories'
78

89
const agent = request.agent(api)
910
const models = Models as any
@@ -61,7 +62,7 @@ describe('Task Solution', () => {
6162
status: 'closed'
6263
})
6364

64-
await models.Order.create({
65+
await OrderFactory({
6566
provider: 'stripe',
6667
amount: 100,
6768
userId: user.id,
@@ -128,7 +129,7 @@ describe('Task Solution', () => {
128129
status: 'closed'
129130
})
130131

131-
await models.Order.create({
132+
await OrderFactory({
132133
provider: 'stripe',
133134
amount: 100,
134135
userId: user.id,
@@ -138,7 +139,7 @@ describe('Task Solution', () => {
138139
paid: true
139140
})
140141

141-
await models.Assign.create({
142+
await AssignFactory({
142143
userId: user.id,
143144
TaskId: task.id,
144145
status: 'pending'
@@ -215,7 +216,7 @@ describe('Task Solution', () => {
215216
status: 'closed'
216217
})
217218

218-
await models.Order.create({
219+
await OrderFactory({
219220
provider: 'stripe',
220221
amount: 100,
221222
userId: user.id,
@@ -284,7 +285,7 @@ describe('Task Solution', () => {
284285
status: 'closed'
285286
})
286287

287-
await models.Order.create({
288+
await OrderFactory({
288289
amount: 100,
289290
userId: user.id,
290291
TaskId: task.id,
@@ -360,12 +361,12 @@ describe('Task Solution', () => {
360361
})
361362
const { body: user, headers } = loginResponse as any
362363

363-
const task = await models.Task.create({
364+
const task = await TaskFactory({
364365
url: 'https://github.com/alexanmtz/test-repository/issues/1',
365366
userId: user.id,
366367
status: 'closed'
367368
})
368-
await models.Assign.create({
369+
await AssignFactory({
369370
userId: user.id,
370371
TaskId: task.id
371372
})
@@ -431,12 +432,12 @@ describe('Task Solution', () => {
431432
})
432433
const { body: user, headers } = loginResponse as any
433434

434-
const task = await models.Task.create({
435+
const task = await TaskFactory({
435436
url: 'https://github.com/alexanmtz/test-repository/issues/1',
436437
userId: user.id,
437438
status: 'closed'
438439
})
439-
await models.Assign.create({
440+
await AssignFactory({
440441
userId: user.id,
441442
TaskId: task.id
442443
})
@@ -480,12 +481,12 @@ describe('Task Solution', () => {
480481
})
481482
const { body: user, headers } = loginResponse as any
482483

483-
const task = await models.Task.create({
484+
const task = await TaskFactory({
484485
url: 'https://github.com/alexanmtz/test-repository/issues/1',
485486
userId: user.id,
486487
status: 'closed'
487488
})
488-
await models.Assign.create({
489+
await AssignFactory({
489490
userId: user.id,
490491
TaskId: task.id
491492
})
@@ -551,12 +552,12 @@ describe('Task Solution', () => {
551552
})
552553
const { body: user, headers } = loginResponse as any
553554

554-
const task = await models.Task.create({
555+
const task = await TaskFactory({
555556
url: 'https://github.com/alexanmtz/test-repository/issues/1',
556557
userId: user.id,
557558
status: 'closed'
558559
})
559-
await models.Assign.create({
560+
await AssignFactory({
560561
userId: user.id,
561562
TaskId: task.id
562563
})

‎test/api/task/task-delete.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { expect } from 'chai'
22
import request from 'supertest'
33
import Models from '../../../src/models'
44
import { createTask, login, registerAndLogin, truncateModels } from '../../helpers'
5+
import { OrderFactory } from '../../factories'
56
import api from '../../../src/server'
67

78
const agent = request.agent(api) as any
@@ -70,7 +71,7 @@ describe('DELETE /tasks/delete/:id', () => {
7071

7172
const { headers, body: createdTask } = task || {}
7273

73-
const order = await models.Order.create({
74+
const order = await OrderFactory({
7475
TaskId: createdTask.id,
7576
amount: 100,
7677
currency: 'USD',

‎test/api/user/userAuth.test.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import Models from '../../../src/models'
77
import UserMail from '../../../src/modules/mail/user'
88
import account from '../../data/stripe/account.json'
99
import sinon from 'sinon'
10+
import { UserFactory } from '../../factories'
1011

1112
const agent = request.agent(api)
1213
const models = Models as any
@@ -210,7 +211,7 @@ describe('AUTH /user', () => {
210211
expect(user.body.error).to.equal('user.change_email.cannot_change_email_for_provider')
211212
})
212213
it('should not change email if user already exist with new email', async () => {
213-
await models.User.create({ email: 'existing-email@example.com', password: 'test' })
214+
await UserFactory({ email: 'existing-email@example.com', password: 'test' })
214215
const res = await registerAndLogin(agent, { email: 'oldemail@example.com', password: 'test' })
215216
const { headers } = res || {}
216217

@@ -386,7 +387,7 @@ describe('AUTH /user', () => {
386387

387388
const updatedUser = await models.User.findByPk(body.id)
388389

389-
await models.User.create({ email: 'new@example.com' })
390+
await UserFactory({ email: 'new@example.com' })
390391

391392
const confirmResponse = await agent
392393
.get('/auth/change-email/confirm')

‎test/api/webhooks/stripe/connect/payout.test.ts‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import Models from '../../../../../src/models'
99
const sinon = require('sinon')
1010

1111
import payoutData from '../../../../data/stripe/payout'
12+
import { UserFactory, PayoutFactory } from '../../../../factories'
1213

1314
const agent = request.agent(api) as any
1415
const models = Models as any
@@ -28,7 +29,7 @@ describe('webhooks for payout', () => {
2829

2930
describe('webhooks for payouts', () => {
3031
it('should notify the transfer when a webhook payout.create is triggered and create a new payout', async () => {
31-
await models.User.create({
32+
await UserFactory({
3233
email: 'teste@mail.com',
3334
password: 'teste',
3435
account_id: 'acct_1CZ5vkLlCJ9CeQRe'
@@ -51,13 +52,13 @@ describe('webhooks for payout', () => {
5152
})
5253

5354
it('should not create a new payout when a webhook payout.create triggers again', async () => {
54-
const user = await models.User.create({
55+
const user = await UserFactory({
5556
email: 'teste@mail.com',
5657
password: 'teste',
5758
account_id: 'acct_1CZ5vkLlCJ9CeQRe'
5859
})
5960

60-
await models.Payout.create({
61+
await PayoutFactory({
6162
source_id: 'po_1CdprNLlCJ9CeQRefEuMMLo6',
6263
amount: 7311,
6364
currency: 'brl',
@@ -85,13 +86,13 @@ describe('webhooks for payout', () => {
8586
})
8687

8788
it('should notify the transfer when a webhook payout.paid is triggered and update payout status', async () => {
88-
const user = await models.User.create({
89+
const user = await UserFactory({
8990
email: 'teste@mail.com',
9091
password: 'teste',
9192
account_id: 'acct_1CZ5vkLlCJ9CeQRe'
9293
})
9394

94-
const newPayout = await models.Payout.create({
95+
const newPayout = await PayoutFactory({
9596
source_id: 'po_1CdprNLlCJ9CeQRefEuMMLo6',
9697
amount: 7311,
9798
currency: 'brl',
@@ -119,13 +120,13 @@ describe('webhooks for payout', () => {
119120
})
120121

121122
it('should update the payout when a webhook payout.updated is triggered', async () => {
122-
const user = await models.User.create({
123+
const user = await UserFactory({
123124
email: 'teste@mail.com',
124125
password: 'teste',
125126
account_id: 'acct_1CZ5vkLlCJ9CeQRe'
126127
})
127128

128-
const newPayout = await models.Payout.create({
129+
const newPayout = await PayoutFactory({
129130
source_id: 'po_1CdprNLlCJ9CeQRefEuMMLo6',
130131
amount: 7311,
131132
currency: 'brl',
@@ -154,7 +155,7 @@ describe('webhooks for payout', () => {
154155
})
155156

156157
it('should know the user when a webhook payout.failed is triggered', async () => {
157-
await models.User.create({
158+
await UserFactory({
158159
email: 'teste@mail.com',
159160
password: 'teste',
160161
account_id: 'acct_1CdjXFAcSPl6ox0l'
@@ -171,13 +172,13 @@ describe('webhooks for payout', () => {
171172
expect(res.body.id).to.equal('evt_1ChFtEAcSPl6ox0l3VSifPWa')
172173
})
173174
it('should update order to failed payout when payout.failed is triggered', async () => {
174-
const user = await models.User.create({
175+
const user = await UserFactory({
175176
email: 'teste@mail.com',
176177
password: 'teste',
177178
account_id: 'acct_1CdjXFAcSPl6ox0l'
178179
})
179180

180-
const payout = await models.Payout.create({
181+
const payout = await PayoutFactory({
181182
source_id: 'po_1CgNDoAcSPl6ox0ljXdVYWx3',
182183
amount: 5000,
183184
currency: 'usd',

0 commit comments

Comments
 (0)