Add permissions attribute to Role#287
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Added the permissions attribute to lib/Resource/Role.php to support WorkOS permissions functionality in PHP applications, enabling access control features like posts:read and posts:write.
- Added missing
permissionsarray property to Role class with PHPDoc annotations - Update requires corresponding documentation changes at workos.com/docs/reference/roles
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Contributor
|
Thanks for adding this @MrCrayfish! Do you mind updating the |
Contributor
Author
|
Fixtures are now updated as of 2ac7ad5 and tests are passing locally. Should be ready to go now. |
mattgd
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently it not possible to use WorkOS permissions in a PHP application as the Role resource is missing the
permissionsattribute. This PR simply addresses the issue. PHPDocs have also been added to the Role class.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.
PHP example will need updating: https://workos.com/docs/reference/roles
Expected new PHP example based on JSON example.