Skip to content

Fix small bug in DirectorySync #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcarvelli merged 2 commits into from
Jun 25, 2025
Merged

Fix small bug in DirectorySync #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5de0177
small unrelated fixes
gcarvelli Jun 24, 2025
feefeeb
one more typo
gcarvelli Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/DirectorySync.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function listGroups(
$params["directory"] = $directory;
}
if ($user) {
$params["user"] = $group;
Copy link
Copy Markdown
Contributor Author

@gcarvelli gcarvelli Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$group is undefined in this scope, this never could have worked.

$params["user"] = $user;
}

$response = Client::request(
Expand Down
4 changes: 2 additions & 2 deletions lib/SSO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ class SSO
* @param null|string $provider Service provider that handles the identity of the user
* @param null|string $connection Unique identifier for a WorkOS Connection
* @param null|string $organization Unique identifier for a WorkOS Organization
* @param null|string $domainHint DDomain hint that will be passed as a parameter to the IdP login page
* @param null|string $loginHint Username/email hint that will be passed as a parameter to the to IdP login page
* @param null|string $domainHint Domain hint that will be passed as a parameter to the IdP login page
Comment thread
gcarvelli marked this conversation as resolved.
* @param null|string $loginHint Username/email hint that will be passed as a parameter to the IdP login page
*
* @throws Exception\UnexpectedValueException
* @throws Exception\ConfigurationException
Expand Down
2 changes: 1 addition & 1 deletion lib/UserManagement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ public function revokeInvitation($invitationId)
* @param null|string $provider Service provider that handles the identity of the user
* @param null|string $connectionId Unique identifier for a WorkOS Connection
* @param null|string $organizationId Unique identifier for a WorkOS Organization
* @param null|string $domainHint DDomain hint that will be passed as a parameter to the IdP login page
* @param null|string $domainHint Domain hint that will be passed as a parameter to the IdP login page
* @param null|string $loginHint Username/email hint that will be passed as a parameter to the to IdP login page
* @param null|string $screenHint The page that the user will be redirected to when the provider is authkit
* @param null|array $providerScopes An array of provider-specific scopes
Expand Down