Skip to content

Patch revoke session response #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awolfden merged 3 commits into from
Oct 15, 2025
Merged

Patch revoke session response #486

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
619d452
Update version to 5.31.0
awolfden Oct 14, 2025
0a3ddef
Update return for revoke session
awolfden Oct 15, 2025
48460cd
Remove unused mock session from test
awolfden Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tests/test_user_management_revoke_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ def setup(self, module_instance: Union[UserManagement, AsyncUserManagement]):
self.user_management = module_instance

def test_revoke_session(self, capture_and_mock_http_client_request):
mock = _mock_session("session_abc")
request_kwargs = capture_and_mock_http_client_request(
self.http_client, mock, 200
)
request_kwargs = capture_and_mock_http_client_request(self.http_client, {}, 200)

response = syncify(
self.user_management.revoke_session(session_id="session_abc")
Expand All @@ -44,4 +41,4 @@ def test_revoke_session(self, capture_and_mock_http_client_request):
assert request_kwargs["url"].endswith("user_management/sessions/revoke")
assert request_kwargs["method"] == "post"
assert request_kwargs["json"] == {"session_id": "session_abc"}
assert response.id == "session_abc"
assert response is None
16 changes: 5 additions & 11 deletions workos/user_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,9 +739,7 @@ def list_sessions(
order: Optional[PaginationOrder] = "desc",
) -> SyncOrAsync["SessionsListResource"]: ...

def revoke_session(
self, *, session_id: str
) -> SyncOrAsync[UserManagementSession]: ...
def revoke_session(self, *, session_id: str) -> SyncOrAsync[None]: ...

def get_magic_auth(self, magic_auth_id: str) -> SyncOrAsync[MagicAuth]:
"""Get the details of a Magic Auth object.
Expand Down Expand Up @@ -1439,15 +1437,13 @@ def list_sessions(
**ListPage[UserManagementSession](**response).model_dump(),
)

def revoke_session(self, *, session_id: str) -> UserManagementSession:
def revoke_session(self, *, session_id: str) -> None:
json = {"session_id": session_id}

response = self._http_client.request(
self._http_client.request(
SESSIONS_REVOKE_PATH, method=REQUEST_METHOD_POST, json=json
)

return UserManagementSession.model_validate(response)

def enroll_auth_factor(
self,
*,
Expand Down Expand Up @@ -2143,15 +2139,13 @@ async def list_sessions(
**ListPage[UserManagementSession](**response).model_dump(),
)

async def revoke_session(self, *, session_id: str) -> UserManagementSession:
async def revoke_session(self, *, session_id: str) -> None:
json = {"session_id": session_id}

response = await self._http_client.request(
await self._http_client.request(
SESSIONS_REVOKE_PATH, method=REQUEST_METHOD_POST, json=json
)

return UserManagementSession.model_validate(response)

async def enroll_auth_factor(
self,
*,
Expand Down