Skip to content
This repository was archived by the owner on May 31, 2021. It is now read-only.

Program Encoding Setting#125

Open
lollo0296 wants to merge 1 commit into
worksofliam:masterfrom
lollo0296:changeencoding
Open

Program Encoding Setting#125
lollo0296 wants to merge 1 commit into
worksofliam:masterfrom
lollo0296:changeencoding

Conversation

@lollo0296

Copy link
Copy Markdown

Hi Barry,

I've been enjoying your ILEditor at my workplace for months now.

I have just one major complaint about it: I work in Germany and the old code of my company is packed with characters like
[ 'ä', 'ö', 'ü', 'ß', '§' ]. ILEditor can't display these characters correctly and the code looks like a mess.

Take a look at this before / after screenshot:
rpgle_before-after

Changes:

  • Configuration node encoding added
  • 2 labels and 1 ComboBox added to Component: Forms/Connection in tab: ILEditor
  • If no encoding is set from User, this is set to standard ISO-8859-1 in method DoEditorsDefaults()
  • Program sets its property Encoding at start on Main() function
// Set Program Encoding
int encodingId = Convert.ToInt32(Config.GetValue("encoding"));
Encoding = Encoding.GetEncoding(encodingId);

It would be awesome if you merge my code in and make a new ILEditor release 😆

@worksofliam

Copy link
Copy Markdown
Owner

Wow, this is a super change.

Of course... there hasn't been a release to ILEditor in quite sometime but as this is quite important I'll take a look into getting it in over the weekend for you.

@worksofliam

worksofliam commented Sep 11, 2020

Copy link
Copy Markdown
Owner

@lollo0296 What is 28591 by default? Is that ISO-8859-1?

@lollo0296

Copy link
Copy Markdown
Author

@worksofliam Yes, it is ISO-8859-1. Same default setting you already had there. Please refer to the Microsoft docs for a full list of encoding IDs.

https://docs.microsoft.com/dotnet/api/system.text.encoding?view=netcore-3.1#list-of-encodings

And thank you man

@lollo0296

lollo0296 commented Sep 15, 2020

Copy link
Copy Markdown
Author

@worksofliam anything new about it ❓

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants