Skip to content

Commit 85798ea

Browse files
committed
test(fixtures): run the public-input tamper test on the base-commit path
The suite split put `tampered_public_input_is_rejected` in `challenge_soundness_suite!`, so it only ran on `GoldilocksEfField` and the base-commit witness path lost its dedicated public-input tamper test. It uses `squaring_chain` and `two_public_inputs` and carries no `Embedding<Target = Base<P>>` bound, unlike the two tests it was grouped with, so it belongs in `soundness_suite!`. Moving it back gives `GoldilocksField` both halves of the public-input pair: the hash-guard rejection and the binding-covector rejection.
1 parent b49471a commit 85798ea

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

  • tooling/provekit-fixtures/tests/shared

tooling/provekit-fixtures/tests/shared/mod.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,11 @@ macro_rules! soundness_suite {
452452
$register();
453453
$crate::shared::public_input_binding_mismatch_is_rejected::<$field>();
454454
}
455+
#[test]
456+
fn tampered_public_input_is_rejected() {
457+
$register();
458+
$crate::shared::tampered_public_input_is_rejected::<$field>();
459+
}
455460
};
456461
}
457462

@@ -460,11 +465,6 @@ macro_rules! soundness_suite {
460465
#[macro_export]
461466
macro_rules! challenge_soundness_suite {
462467
($field:ty, $register:path) => {
463-
#[test]
464-
fn tampered_public_input_is_rejected() {
465-
$register();
466-
$crate::shared::tampered_public_input_is_rejected::<$field>();
467-
}
468468
#[test]
469469
fn tampered_challenge_is_rejected() {
470470
$register();

0 commit comments

Comments
 (0)