Skip to content

Commit d227376

Browse files
committed
Keep make verification aligned with CI
The Makefile convenience target only ran the repository check and build, while npm and CI verification also cover AI integration and visual baseline integrity. Delegate make verify to the authoritative npm pipeline and expose verify-ai explicitly so local shortcuts do not miss regressions. Constraint: Contributors may use make verify as the local pre-push check. Rejected: Duplicate the full command chain in Makefile | delegating to npm run verify avoids future drift between verification surfaces. Confidence: high Scope-risk: narrow Directive: Keep all verification entry points aligned with the authoritative npm verify pipeline. Tested: make -n verify; make verify; npm audit --omit=dev; git diff --check Not-tested: GitHub Actions execution after this commit.
1 parent 54c00da commit d227376

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

Makefile

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,22 @@
1-
.PHONY: help verify verify-repo verify-visual build
1+
.PHONY: help verify verify-repo verify-ai verify-visual build
22

33
help:
44
@echo "Available targets:"
5-
@echo " verify Run repository and app verification"
5+
@echo " verify Run full repository, AI, build, and visual verification"
66
@echo " verify-repo Check repository structure and source data links"
7+
@echo " verify-ai Verify AI backend integration"
78
@echo " verify-visual Run visual baseline verification"
89
@echo " build Build the app"
910

10-
verify: verify-repo build
11+
verify:
12+
npm run verify
1113

1214
verify-repo:
1315
python3 scripts/check_repository.py
1416

17+
verify-ai:
18+
npm run verify:ai
19+
1520
verify-visual:
1621
python3 scripts/verify_visual_baseline.py
1722

scripts/check_repository.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
ROOT / 'README.md',
1313
ROOT / 'package.json',
1414
ROOT / 'next.config.js',
15+
ROOT / 'Makefile',
1516
ROOT / 'app' / 'layout.jsx',
1617
ROOT / 'app' / 'page.jsx',
1718
ROOT / 'components' / 'ChatSimulator.jsx',
@@ -80,6 +81,7 @@
8081
open_source_doc = (ROOT / 'docs' / 'open-source.md').read_text()
8182
gitignore_source = (ROOT / '.gitignore').read_text()
8283
next_config_source = (ROOT / 'next.config.js').read_text()
84+
makefile_source = (ROOT / 'Makefile').read_text()
8385

8486

8587
if 'turbopack' not in next_config_source or 'root: __dirname' not in next_config_source:
@@ -90,6 +92,8 @@
9092
raise SystemExit('package.json must point homepage to the production demo URL')
9193
if package_data.get('scripts', {}).get('verify') != 'python3 scripts/check_repository.py && npm run verify:ai && npm run build && python3 scripts/verify_visual_baseline.py':
9294
raise SystemExit('package.json must expose the full local verification pipeline')
95+
if 'verify:\n\tnpm run verify' not in makefile_source or 'verify-ai:\n\tnpm run verify:ai' not in makefile_source:
96+
raise SystemExit('Makefile verify target must delegate to the full npm verification pipeline')
9397
if lock_data.get('packages', {}).get('', {}).get('license') != 'MIT':
9498
raise SystemExit('package-lock.json root package metadata must be synced with package.json')
9599
if package_data.get('scripts', {}).get('verify:ai') != 'node --no-warnings scripts/verify_ai_integration.mjs':

0 commit comments

Comments
 (0)