Skip to content

Commit 739d431

Browse files
committed
GH Actions/linting: show deprecations when linting
While rare, there are some deprecations which PHP can show when a file is being linted. By default these are ignored by PHP-Parallel-Lint. However, there is an option to show them, so let's turn that option on. To make the option effective, we also need to ensure that PHP is run in a way that all errors will be shown, which is not the case by default, so this also sets some `ini-values` for PHP to a more optimal setting for CI. Lastly, in the command, let's also make the package directory iteration a little faster by preventing parallel lint from having to iterate through the `.git` directory when there are no PHP files to be found there anyway.
1 parent 2fc4bbd commit 739d431

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/reusable-code-quality.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
uses: shivammathur/setup-php@v2
3030
with:
3131
php-version: 'latest'
32+
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
3233
tools: cs2pr
3334
env:
3435
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -50,7 +51,7 @@ jobs:
5051

5152
- name: Run Linter
5253
if: steps.check_linter_file.outputs.files_exists == 'true'
53-
run: vendor/bin/parallel-lint -j 10 . --exclude vendor --checkstyle | cs2pr
54+
run: vendor/bin/parallel-lint -j 10 . --show-deprecated --exclude vendor --exclude .git --checkstyle | cs2pr
5455

5556
phpcs: #----------------------------------------------------------------------
5657
name: PHPCS

0 commit comments

Comments
 (0)