Skip to content

Commit f79edd3

Browse files
swissspidyCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 6839d4b commit f79edd3

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.github/workflows/reusable-functional.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,12 @@ on:
1010
required: true
1111
dbtype:
1212
type: string
13-
required: true
13+
required: false
14+
default: 'mysql'
1415
mysql:
1516
type: string
16-
required: true
17+
required: false
18+
default: ''
1719
object_cache:
1820
type: string
1921
required: false

.github/workflows/reusable-testing.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ jobs:
444444
with:
445445
php: ${{ matrix.php }}
446446
wp: ${{ matrix.wp }}
447-
dbtype: ${{ matrix.dbtype }}
447+
dbtype: ${{ matrix.dbtype || 'mysql' }}
448448
mysql: ${{ matrix.mysql }}
449449
object_cache: ${{ matrix.object_cache }}
450450
coverage: ${{ matrix.coverage }}

.github/workflows/reusable-unit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
custom-cache-suffix: $(date -u "+%Y-%m")
4545

4646
# PHPUnit 10+ may fail a test run when the "old" configuration format is used.
47-
# Luckily, there is a build-in migration tool since PHPUnit 9.3.
47+
# Luckily, there is a built-in migration tool since PHPUnit 9.3.
4848
- name: Migrate PHPUnit configuration for PHPUnit 10+
4949
if: ${{ inputs.php >= 8.2 || inputs.php == 'nightly' }}
5050
continue-on-error: true

0 commit comments

Comments
 (0)