Skip to content

Add coverage input to reusable-testing #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 3 commits into from
Jun 10, 2025
Merged

Add coverage input to reusable-testing #135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ade809
add with-coverage input
trepmal Jun 10, 2025
119e1cd
account for coverage setting in prepare-functional matrix
trepmal Jun 10, 2025
9d14852
don't forget -c
trepmal Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 59 additions & 2 deletions .github/workflows/reusable-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ on:
type: string
required: false
default: '4.9'
with-coverage:
description: 'Include coverages tests.'
type: boolean
required: false
default: true

# Cancels all previous workflow runs for the same branch that have not yet completed.
concurrency:
Expand Down Expand Up @@ -222,7 +227,31 @@ jobs:
id: set-matrix
run: |
if [[ $FILE_EXISTS == 'true' ]]; then
echo "matrix=$(jq -c '.include |= map(with_entries(select(.key == "php", .key == "coverage"))) | .include |= map(select(.php >= "${{ inputs.minimum-php }}")) | .include |= unique_by(.php)' <<< $BASE_MATRIX)" >> $GITHUB_OUTPUT
echo "matrix=$(jq -c \
--argjson with_coverage_flag "${{ inputs.with-coverage }}" \
--arg minimum_php "${{ inputs.minimum-php }}" \
--arg minimum_wp "${{ inputs.minimum-wp }}" \
'
.include |= (
map(
# First, select only the versions that meet all minimum requirements
select(
(.php >= $minimum_php) and
(.wp == "latest" or .wp >= $minimum_wp)
) |

# Next, update the coverage flag on the remaining items
if $with_coverage_flag == false and .coverage == true then
.coverage = false
else
.
end
) |

# Finally, get the unique entries
unique_by(.php)
)
' <<< "$BASE_MATRIX")" >> $GITHUB_OUTPUT
else
echo "matrix=" >> $GITHUB_OUTPUT
fi
Expand Down Expand Up @@ -313,7 +342,35 @@ jobs:
id: set-matrix
run: |
if [[ $FILE_EXISTS == 'true' ]]; then
echo "matrix=$(jq -c '.include |= map(select(.wp == "4.9").wp |= "${{ inputs.minimum-wp }}") | .include |= map(select(.php >= "${{ inputs.minimum-php }}"))' <<< $BASE_MATRIX)" >> $GITHUB_OUTPUT
echo "matrix=$(jq -c \
--argjson with_coverage_flag "${{ inputs.with-coverage }}" \
--arg minimum_php "${{ inputs.minimum-php }}" \
--arg minimum_wp "${{ inputs.minimum-wp }}" \
'
# First, select only the versions that meet all minimum requirements
.include |= (
map(
select(
.php >= $minimum_php
) |
# Next, update the coverage flag on the remaining items
if $with_coverage_flag == false and .coverage == true then
.coverage = false
else
.
end
)
) |

# Reassign WP4.9 to minimum_wp
.include |= (
map(
select(
.wp == "4.9"
).wp |= $minimum_wp
)
)
' <<< "$BASE_MATRIX" )" >> $GITHUB_OUTPUT
else
echo "matrix=" >> $GITHUB_OUTPUT
fi
Expand Down