Add persistent object cache support to matrix#227
Merged
swissspidy merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the reusable CI workflow test matrix to exercise persistent object cache scenarios (SQLite object cache) during functional tests.
Changes:
- Adds new functional-matrix entries that set
object_cache: sqlitefor selected SQLite runs. - Updates the functional job name to surface the object cache mode in the job title.
- Exports
WP_CLI_TEST_OBJECT_CACHEfrom the matrix into the functional job environment.
Comments suppressed due to low confidence (1)
.github/workflows/reusable-testing.yml:292
- The matrix no longer includes a
php: nightly/wp: trunkrun againstmysql-8.0(nightly now only runs on mysql-8.4 and sqlite). If this was done intentionally (e.g., to reduce redundancy or due to mysql-8.0 issues), it would be helpful to document the rationale; otherwise consider re-adding it to avoid dropping coverage for that DB version.
{
"php": "nightly",
"wp": "trunk",
"mysql": "mysql-8.4"
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
swissspidy
added a commit
that referenced
this pull request
Mar 24, 2026
SQlite Object Cache Plugin requires WP 5.5+. Follow-up to #227.
swissspidy
added a commit
that referenced
this pull request
Mar 24, 2026
Reverts a change from #227.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.