Skip to content

feat: add --format param for core checksums verification#140

Merged
swissspidy merged 21 commits into
wp-cli:mainfrom
alaminfirdows:fix/core-checksums-format
Aug 18, 2025
Merged

feat: add --format param for core checksums verification#140
swissspidy merged 21 commits into
wp-cli:mainfrom
alaminfirdows:fix/core-checksums-format

Conversation

@alaminfirdows

@alaminfirdows alaminfirdows commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR adds support for the --format parameter to the wp core verify-checksums command, enabling structured output formats like plain, table, json, csv, yaml, count, and others.

It brings consistency with commands like plugin verify-checksums, improving automation and scripting support.

✅ Supported formats

  • plain (default)
  • table
  • json
  • csv
  • yaml
  • count

🧪 Test Guide

  • Run command in default format: wp core verify-checksums

  • Run with JSON output: wp core verify-checksums --format=json

  • Run with CSV output: wp core verify-checksums --format=csv

  • Trigger an error (e.g., modify a core file) to see results in all formats.

Notes

  • No breaking changes introduced.
  • Falls back to default table if --format is not specified.
  • Useful for CI scripts or plugin/tooling integrations.

Resolved: #94

@alaminfirdows alaminfirdows requested a review from a team as a code owner August 7, 2025 05:56
@ernilambar

Copy link
Copy Markdown
Member

@alaminfirdows Can you please make sure that tests are not failing? This should not be a breaking change I believe.

@codecov

codecov Bot commented Aug 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@alaminfirdows

Copy link
Copy Markdown
Contributor Author

@ernilambar could you please check again?

@alaminfirdows

Copy link
Copy Markdown
Contributor Author

@swissspidy, @thelovekesh could you please review this?

We’re working on a tool based on this, and we’re eagerly waiting for this PR to be merged. It’s going to be a real game-changer for our users!

@swissspidy swissspidy added the command:core-verify-checksums Related to 'core verify-checksums' command label Aug 15, 2025
Comment thread src/Checksum_Core_Command.php Outdated
Comment thread src/Checksum_Core_Command.php Outdated
Comment thread src/Checksum_Core_Command.php Outdated
Comment thread features/checksum-core.feature Outdated
@alaminfirdows

Copy link
Copy Markdown
Contributor Author

@swissspidy @ernilambar I believe it’s ready for merging. I’ve completed all my parts.

Comment thread src/Checksum_Core_Command.php Outdated
@swissspidy swissspidy merged commit cc38427 into wp-cli:main Aug 18, 2025
42 checks passed
@swissspidy swissspidy added this to the 2.3.2 milestone Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:core-verify-checksums Related to 'core verify-checksums' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --format argument to wp core verify-checksums

3 participants