Merge branch 'main' into copilot/fix-core-install-error-255

Author: swissspidy

.github/workflows/code-quality.yml

@@ -6,6 +6,8 @@ on:
     branches:
       - main
       - master
+  schedule:
+     - cron: '17 2 * * *' # Run every day on a seemly random time.
 
 jobs:
   code-quality:

.github/workflows/copilot-setup-steps.yml

@@ -17,17 +17,17 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v6
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
 
       - name: Check existence of composer.json file
         id: check_composer_file
-        uses: andstor/file-existence-action@v3
+        uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3
         with:
           files: "composer.json"
 
       - name: Set up PHP environment
         if: steps.check_composer_file.outputs.files_exists == 'true'
-        uses: shivammathur/setup-php@v2
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2
         with:
           php-version: 'latest'
           ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
@@ -38,7 +38,7 @@ jobs:
 
       - name: Install Composer dependencies & cache dependencies
         if: steps.check_composer_file.outputs.files_exists == 'true'
-        uses: ramsey/composer-install@v3
+        uses: ramsey/composer-install@3cf229dc2919194e9e36783941438d17239e8520 # v3
         env:
           COMPOSER_ROOT_VERSION: dev-${{ github.event.repository.default_branch }}
         with:

.github/workflows/issue-triage.yml

@@ -13,6 +13,13 @@ name: Issue and PR Triage
         required: false
         type: string
 
+permissions:
+  issues: write
+  pull-requests: write
+  actions: write
+  contents: read
+  models: read
+
 jobs:
   issue-triage:
     uses: wp-cli/.github/.github/workflows/reusable-issue-triage.yml@main

.github/workflows/regenerate-readme.yml

@@ -10,6 +10,10 @@ on:
       - "features/**"
       - "README.md"
 
+permissions:
+  contents: write
+  pull-requests: write
+
 jobs:
   regenerate-readme:
     uses: wp-cli/.github/.github/workflows/reusable-regenerate-readme.yml@main

.github/workflows/welcome-new-contributors.yml

@@ -7,6 +7,9 @@ on:
       - main
       - master
 
+permissions:
+  pull-requests: write
+
 jobs:
   welcome:
     uses: wp-cli/.github/.github/workflows/reusable-welcome-new-contributors.yml@main

.typos.toml

@@ -0,0 +1,6 @@
+[default]
+extend-ignore-re = [
+	"(?Rm)^.*(#|//)\\s*spellchecker:disable-line$",
+	"(?s)(#|//)\\s*spellchecker:off.*?\\n\\s*(#|//)\\s*spellchecker:on",
+	"(#|//)\\s*spellchecker:ignore-next-line\\n.*"
+]

README.md

@@ -239,6 +239,8 @@ Transforms an existing single-site installation into a multisite installation.
 wp core multisite-convert [--title=<network-title>] [--base=<url-path>] [--subdomains] [--skip-config]
 ~~~
 
+**Alias:** `install-network`
+
 Creates the multisite database tables, and adds the multisite constants
 to wp-config.php.
 
@@ -344,6 +346,8 @@ Updates WordPress to a newer version.
 wp core update [<zip>] [--minor] [--version=<version>] [--force] [--locale=<locale>] [--format=<format>] [--insecure]
 ~~~
 
+**Alias:** `upgrade`
+
 Defaults to updating WordPress to the latest version.
 
 If you see "Error: Another update is currently in progress.", you may

composer.json

@@ -13,7 +13,7 @@
     ],
     "require": {
         "composer/semver": "^1.4 || ^2 || ^3",
-        "wp-cli/wp-cli": "^2.12"
+        "wp-cli/wp-cli": "^2.13"
     },
     "require-dev": {
         "wp-cli/checksum-command": "^1 || ^2",

features/core-check-update.feature

@@ -70,3 +70,19 @@ Feature: Check for more recent versions
       """
       ---
       """
+
+  Scenario: Check update shows warning when version check API fails
+    Given a WP install
+    And that HTTP requests to https://api.wordpress.org/core/version-check/1.7/ will respond with:
+      """
+      HTTP/1.1 500 Internal Server Error
+      Content-Type: text/plain
+
+      <Error body>
+      """
+
+    When I try `wp core check-update --force-check`
+    Then STDERR should contain:
+      """
+      Warning: Failed to check for updates
+      """

features/core-update.feature

@@ -167,7 +167,7 @@ Feature: Update WordPress core
     When I run `wp core update`
     Then STDOUT should contain:
       """
-      WordPress is up to date
+      WordPress is up to date at version
       """
     And STDOUT should not contain:
       """
@@ -419,3 +419,57 @@ Feature: Update WordPress core
       """
       </div>
       """
+
+  @require-php-7.0 @require-wp-6.1
+  Scenario: Attempting to downgrade without --force shows helpful message
+    Given a WP install
+
+    When I run `wp core version`
+    Then save STDOUT as {WP_CURRENT_VERSION}
+
+    When I try `wp core update --version=6.0`
+    Then STDOUT should contain:
+      """
+      WordPress is up to date at version
+      """
+    And STDOUT should contain:
+      """
+      is older than the current version
+      """
+    And STDOUT should contain:
+      """
+      Use --force to update anyway
+      """
+    And STDOUT should not contain:
+      """
+      Success:
+      """
+    And the return code should be 0
+
+    When I run `wp core update --version=6.0 --force`
+    Then STDOUT should contain:
+      """
+      Updating to version 6.0
+      """
+    And STDOUT should contain:
+      """
+      Success: WordPress updated successfully.
+      """
+
+  Scenario: Show helpful tip when update is locked
+    Given a WP install
+
+    When I run `wp option update core_updater.lock 100000000000000`
+    And I try `wp core update --version=trunk`
+    Then STDERR should contain:
+      """
+      Another update is currently in progress. You may need to run `wp option delete core_updater.lock` after verifying another update isn't actually running.
+      """
+    And the return code should be 1
+
+    # Clean up the lock
+    When I run `wp option delete core_updater.lock`
+    Then STDOUT should contain:
+      """
+      Success:
+      """