Merge branch 'main' into copilot/fix-password-escaping-issue

Author: swissspidy

features/core-install.feature

@@ -193,51 +193,6 @@ Feature: Install WordPress core
     When I run `wp user check-password wpcli 'R^^CzY;G"iZ@]H9b,' --escape-chars`
     Then the return code should be 0
 
-  @less-than-php-7
-  Scenario: Install WordPress with locale set to de_DE on WP < 4.0
-    Given an empty directory
-    And an empty cache
-    And a database
-
-    When I run `wp core download --version=3.7 --locale=de_DE`
-    And save STDOUT 'Downloading WordPress ([\d\.]+)' as {VERSION}
-    And I run `echo {VERSION}`
-    Then STDOUT should contain:
-      """
-      3.7
-      """
-    And the wp-settings.php file should exist
-    And the {SUITE_CACHE_DIR}/core/wordpress-{VERSION}-de_DE.tar.gz file should exist
-
-    When I run `wp config create --dbname={DB_NAME} --dbuser={DB_USER} --dbpass={DB_PASSWORD} --dbhost={DB_HOST} --locale=de_DE --skip-check`
-    Then STDOUT should be:
-      """
-      Success: Generated 'wp-config.php' file.
-      """
-
-    # Old versions of WP can generate wpdb database errors if the WP tables don't exist, so STDERR may or may not be empty
-    When I try `wp core install --url=example.org --title=Test --admin_user=testadmin --admin_email=testadmin@example.com --admin_password=newpassword --locale=de_DE --skip-email`
-    Then STDERR should contain:
-      """
-      Warning: The flag --locale=de_DE is being ignored as it requires WordPress 4.0+.
-      """
-    And STDOUT should contain:
-      """
-      Success: WordPress installed successfully.
-      """
-
-    When I run `wp core version`
-    Then STDOUT should contain:
-      """
-      3.7
-      """
-
-    When I run `wp taxonomy list`
-    Then STDOUT should contain:
-      """
-      Kategorien
-      """
-
   # This test downgrades to an older WordPress version, but the SQLite plugin requires 6.0+
   @require-mysql
   Scenario: Install WordPress with locale set to de_DE on WP >= 4.0

src/Core_Command.php

@@ -156,6 +156,7 @@ public function check_update( $args, $assoc_args ) {
 	 *     md5 hash verified: c5366d05b521831dd0b29dfc386e56a5
 	 *     Success: WordPress downloaded.
 	 *
+	 * @skipglobalargcheck Reusing `--path` on purpose.
 	 * @when before_wp_load
 	 *
 	 * @param array{0?: string} $args Positional arguments.
@@ -467,6 +468,8 @@ public function is_installed( $args, $assoc_args ) {
 	 *     # Install WordPress without disclosing admin_password to bash history
 	 *     $ wp core install --url=example.com --title=Example --admin_user=supervisor --admin_email=info@example.com --prompt=admin_password < admin_password.txt
 	 *
+	 * @skipglobalargcheck Reusing `--url` on purpose.
+	 *
 	 * @param string[] $args Positional arguments. Unused.
 	 * @param array{url: string, title: string, admin_user: string, admin_password?: string, admin_email: string, locale?: string, 'skip-email'?: bool} $assoc_args Associative arguments.
 	 */
@@ -596,6 +599,7 @@ public function multisite_convert( $args, $assoc_args ) {
 	 *     Added multisite constants to wp-config.php.
 	 *     Success: Network installed. Don't forget to set up rewrite rules.
 	 *
+	 * @skipglobalargcheck Reusing `--url` on purpose.
 	 * @subcommand multisite-install
 	 *
 	 * @param string[] $args Positional arguments. Unused.