Skip to content

Tests: Further improve Windows compatibility #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 5 commits into from
Apr 2, 2026
Merged

Tests: Further improve Windows compatibility #327

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45528b5
Adjust quotes
swissspidy Mar 29, 2026
fd9ea85
escape
swissspidy Mar 29, 2026
0dce7a4
Use eval-file
swissspidy Apr 1, 2026
090f106
Update features/core.feature
swissspidy Apr 1, 2026
55280a2
Skip some more tests on Windows
swissspidy Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/core.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ Feature: Manage WordPress installation
"""
And the return code should be 0

When I run `wp eval 'echo $GLOBALS["current_site"]->domain;'`
When I run `wp eval "echo $GLOBALS['current_site']->domain;"`
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change improves Windows compatibility for this command, other wp eval calls in this file still use single quotes (e.g., on line 249), which can cause parsing issues on Windows. For consistency and to fully address the compatibility issue, please consider updating all wp eval calls in this file to use double quotes for the command argument.

Then STDOUT should be:
"""
foobar.org
Expand Down
Loading