Skip to content

Skip a couple of tests on Windows#140

Merged
swissspidy merged 1 commit intomainfrom
fix/windows
Apr 1, 2026
Merged

Skip a couple of tests on Windows#140
swissspidy merged 1 commit intomainfrom
fix/windows

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@swissspidy swissspidy requested a review from a team as a code owner April 1, 2026 14:33
Copilot AI review requested due to automatic review settings April 1, 2026 14:33
@swissspidy swissspidy added this to the 2.3.8 milestone Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request skips two WP-Cron scenarios on Windows due to 500 Internal Server Errors and adds TODO comments for future investigation. The feedback suggests improving these TODOs by including links to tracking issues to ensure the problems are properly documented and resolved.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Behat feature coverage for the cron command by marking two scenarios as Windows-skipped due to an observed 500 Internal Server Error on that platform.

Changes:

  • Added @skip-windows tag to the “Testing WP-Cron” scenario.
  • Added @skip-windows tag to the “Don't trigger cron when ALTERNATE_WP_CRON is defined” scenario.
  • Added TODO notes explaining the reason for the skips.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy merged commit 16e84a3 into main Apr 1, 2026
70 checks passed
@swissspidy swissspidy deleted the fix/windows branch April 1, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants