Skip to content

Fix: wp menu item update --position does not reshuffle other menu items #861

Fix: wp menu item update --position does not reshuffle other menu items

Fix: wp menu item update --position does not reshuffle other menu items #861

Triggered via pull request March 19, 2026 10:31
Status Failure
Total duration 33s
Artifacts

code-quality.yml

on: pull_request
code-quality  /  Lint GitHub Actions workflows
8s
code-quality / Lint GitHub Actions workflows
code-quality  /  Lint PHP files
20s
code-quality / Lint PHP files
code-quality  /  Lint Gherkin Feature files
13s
code-quality / Lint Gherkin Feature files
code-quality  /  Spell check
8s
code-quality / Spell check
code-quality  /  PHPCS
26s
code-quality / PHPCS
code-quality  /  PHPStan
29s
code-quality / PHPStan
Fit to window
Zoom out
Zoom in

Annotations

12 errors
code-quality / PHPCS
Process completed with exit code 1.
code-quality / PHPCS: src/Menu_Item_Command.php#L722
Use placeholders and $wpdb->prepare(); found interpolated variable {$ids_sql} at "UPDATE {$wpdb->posts} SET menu_order = CASE ID {$case_clauses} END WHERE ID IN ({$ids_sql})"
code-quality / PHPCS: src/Menu_Item_Command.php#L722
Use placeholders and $wpdb->prepare(); found interpolated variable {$case_clauses} at "UPDATE {$wpdb->posts} SET menu_order = CASE ID {$case_clauses} END WHERE ID IN ({$ids_sql})"
code-quality / PHPCS
Process completed with exit code 1.
code-quality / PHPStan
Process completed with exit code 1.
code-quality / PHPStan: src/Menu_Item_Command.php#L709
Variable $pending_menu_order_updates in empty() always exists and is always falsy.
code-quality / PHPStan: src/Menu_Item_Command.php#L686
Comparison operation "<=" between *NEVER* and int<0, max> results in an error.
code-quality / PHPStan: src/Menu_Item_Command.php#L678
Comparison operation "<=" between int<0, max> and *NEVER* results in an error.
code-quality / PHPStan: src/Menu_Item_Command.php#L676
Comparison operation "<" between int<1, max> and *NEVER* results in an error.
code-quality / PHPStan: src/Menu_Item_Command.php#L675
Strict comparison using !== between int<1, max> and *NEVER* will always evaluate to true.
code-quality / PHPStan: src/Menu_Item_Command.php#L675
Result of && is always false.
code-quality / PHPStan: src/Menu_Item_Command.php#L675
Comparison operation ">" between 0 and 0 is always false.