Tests: further Windows compatibility fixes (#609)

Author: swissspidy

features/comment-recount.feature

@@ -11,7 +11,14 @@ Feature: Recount comments on a post
       3
       """
 
-    When I run `wp eval 'global $wpdb; $wpdb->update( $wpdb->posts, array( "comment_count" => 1 ), array( "ID" => 1 ) ); clean_post_cache( 1 );'`
+    Given a recount-comments.php file:
+      """
+      <?php
+      global $wpdb;
+      $wpdb->update( $wpdb->posts, array( "comment_count" => 1 ), array( "ID" => 1 ) );
+      clean_post_cache( 1 );
+      """
+    When I run `wp eval-file recount-comments.php`
     And I run `wp post get 1 --field=comment_count`
     Then STDOUT should be:
       """

features/comment.feature

@@ -289,6 +289,7 @@ Feature: Manage WordPress comments
       """
     And the return code should be 0
 
+  @skip-windows
   Scenario: Approving/unapproving comments with multidigit comment ID
     Given I run `wp comment delete $(wp comment list --field=ID)`
     And I run `wp comment generate --count=10 --quiet`
@@ -343,6 +344,7 @@ Feature: Manage WordPress comments
       """
     And the return code should be 0
 
+  @skip-windows
   Scenario: Spam/unspam comments with multidigit comment ID
     Given I run `wp comment delete $(wp comment list --field=ID)`
     And I run `wp comment generate --count=10 --quiet`
@@ -392,6 +394,7 @@ Feature: Manage WordPress comments
       """
     And the return code should be 0
 
+  @skip-windows
   Scenario: Trash/untrash comments with multidigit comment ID
     Given I run `wp comment delete $(wp comment list --field=ID) --force`
     And I run `wp comment generate --count=10 --quiet`

features/post-block.feature

@@ -1,5 +1,7 @@
 Feature: Manage post custom fields
 
+  # Windows likes to include the quotes of the `"via STDIN"` string.
+  @skip-windows
   Scenario: Postmeta CRUD
     Given a WP install
 
@@ -34,7 +36,7 @@ Feature: Manage post custom fields
       ["1","2"]
       """
 
-    When I run `echo 'via STDIN' | wp post-meta set 1 foo`
+    When I run `echo "via STDIN" | wp post-meta set 1 foo`
     And I run `wp post-meta get 1 foo`
     Then STDOUT should be:
       """

features/post-meta.feature

@@ -224,7 +224,7 @@ Feature: Manage WordPress posts
       """
     And a create-post.sh file:
       """
-      cat content.html | wp post create --post_title='Test post' --post_excerpt="A multiline
+      cat content.html | wp post create --post_title="Test post" --post_excerpt="A multiline
       excerpt" --porcelain -
       """
 
@@ -265,14 +265,14 @@ Feature: Manage WordPress posts
       }
       """
 
-    When I try `EDITOR='ex -i NONE -c q!' wp post edit {POST_ID}`
+    When I try `EDITOR="ex -i NONE -c q!" wp post edit {POST_ID}`
     Then STDERR should contain:
       """
       No change made to post content.
       """
     And the return code should be 0
 
-    When I run `EDITOR='ex -i NONE -c %s/content/bunkum -c wq' wp post edit {POST_ID}`
+    When I run `EDITOR="ex -i NONE -c %s/content/bunkum -c wq" wp post edit {POST_ID}`
     Then STDERR should be empty
     And STDOUT should contain:
       """
@@ -473,7 +473,7 @@ Feature: Manage WordPress posts
       My\Post
       """
 
-    When I run `wp post update {POST_ID} --post_content='var isEmailValid = /^\S+@\S+.\S+$/.test(email);'`
+    When I run `wp post update {POST_ID} --post_content="var isEmailValid = /^\S+@\S+.\S+$/.test(email);"`
     Then STDOUT should not be empty
 
     When I run `wp post get {POST_ID} --field=content`

features/post.feature

@@ -38,6 +38,7 @@ Feature: Manage sites in a multisite installation
       http://first.example.com
       """
 
+  @skip-windows
   Scenario: Delete a site by id
     Given a WP multisite subdirectory install
 
@@ -77,6 +78,7 @@ Feature: Manage sites in a multisite installation
     When I try the previous command again
     Then the return code should be 1
 
+  @skip-windows
   Scenario: Filter site list
     Given a WP multisite install
 
@@ -212,6 +214,7 @@ Feature: Manage sites in a multisite installation
       """
     And the return code should be 1
 
+  @skip-windows
   Scenario: Get site info
     Given a WP multisite install
 

features/site.feature

@@ -40,7 +40,14 @@ Feature: Recount terms on a taxonomy
       """
       1
       """
-    When I run `wp eval 'global $wpdb; $wpdb->update( $wpdb->term_taxonomy, array( "count" => 3 ), array( "term_id" => {TERM_ID} ) ); clean_term_cache( {TERM_ID}, "category" );'`
+    Given a recount-terms.php file:
+      """
+      <?php
+      global $wpdb;
+      $wpdb->update( $wpdb->term_taxonomy, array( "count" => 3 ), array( "term_id" => {TERM_ID} ) );
+      clean_term_cache( {TERM_ID}, "category" );
+      """
+    When I run `wp eval-file recount-terms.php`
     And I run `wp term get category {TERM_ID} --field=count`
     Then STDOUT should be:
       """

features/term-recount.feature

@@ -181,7 +181,7 @@ Feature: Manage WordPress terms
       My\Term\Description
       """
 
-    When I run `wp term update category {TERM_ID} --name='My\New\Term' --description='var isEmailValid = /^\S+@\S+.\S+$/.test(email);'`
+    When I run `wp term update category {TERM_ID} --name="My\New\Term" --description="var isEmailValid = /^\S+@\S+.\S+$/.test(email);"`
     Then STDOUT should not be empty
 
     When I run `wp term get category {TERM_ID} --field=name`

features/term.feature

@@ -271,10 +271,15 @@ Feature: Manage user custom fields
     When I run `wp user application-password list {USER_ID} --name=someapp --field=uuid`
     Then save STDOUT as {UUID}
 
-    When I run `wp user application-password get {USER_ID} {UUID} --field=password | sed 's/\$/\\\$/g'`
+    When I run `wp user application-password get {USER_ID} {UUID} --field=password`
     Then save STDOUT as {HASH}
 
-    When I run `wp eval "var_export( wp_check_password( '{PASSWORD}', '{HASH}', {USER_ID} ) );"`
+    Given a check-password.php file:
+      """
+      <?php
+      var_export( wp_check_password( '{PASSWORD}', '{HASH}', {USER_ID} ) );
+      """
+    When I run `wp eval-file check-password.php`
     Then STDOUT should contain:
       """
       true
@@ -297,10 +302,15 @@ Feature: Manage user custom fields
     When I run `wp user application-password list {USER_ID} --name=someapp --field=uuid`
     Then save STDOUT as {UUID}
 
-    When I run `wp user application-password get {USER_ID} {UUID} --field=password | sed 's/\$/\\\$/g'`
+    When I run `wp user application-password get {USER_ID} {UUID} --field=password`
     Then save STDOUT as {HASH}
 
-    When I run `wp eval "var_export( wp_verify_fast_hash( '{PASSWORD}', '{HASH}', {USER_ID} ) );"`
+    Given a verify-fast-hash.php file:
+      """
+      <?php
+      var_export( wp_verify_fast_hash( '{PASSWORD}', '{HASH}', {USER_ID} ) );
+      """
+    When I run `wp eval-file verify-fast-hash.php`
     Then STDOUT should contain:
       """
       true

features/user-application-password.feature

@@ -103,6 +103,7 @@ Feature: Import users from CSV
       }
       """
 
+  @skip-windows
   Scenario: Import users from a CSV file generated by `wp user list`
     Given a WP install