Skip to content

Ensure wp user update Returns Non-Zero Exit Code for Invalid Users #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrsdizzie merged 4 commits into from
Mar 19, 2025
Merged

Ensure wp user update Returns Non-Zero Exit Code for Invalid Users #527

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b3df74
Update non-user command
karthick-murugan Mar 18, 2025
c007708
Adding tests and feedback
karthick-murugan Mar 19, 2025
ba7b5f2
Feedback changes updated
karthick-murugan Mar 19, 2025
af2d210
Space removal update
karthick-murugan Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions features/user.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,4 +728,12 @@ Feature: Manage WordPress users
"""
newtestuser
"""
Scenario: Updating an invalid user should return an error
Given a WP install
When I try `wp user update 9999 --user_pass=securepassword`
Comment thread
mrsdizzie marked this conversation as resolved.
Outdated
Then the return code should be 1
And STDERR should contain:
"""
Error: No valid users found.
"""

4 changes: 4 additions & 0 deletions src/User_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,10 @@ public function update( $args, $assoc_args ) {
$user_ids[] = $user->ID;
}

if ( empty( $user_ids ) ) {
WP_CLI::error( 'No valid users found.' );
}

$skip_email = Utils\get_flag_value( $assoc_args, 'skip-email' );
if ( $skip_email ) {
add_filter( 'send_email_change_email', '__return_false' );
Expand Down