Test breakages run -> try; return code and STDOUT checks.

Author: gitlost

features/plugin-deactivate.feature

@@ -20,6 +20,7 @@ Feature: Deactivate WordPress plugins
       Warning: The 'edit-flow' plugin could not be found.
       Error: No plugins deactivated.
       """
+    And STDOUT should be empty
     And the return code should be 1
 
     When I try `wp plugin deactivate akismet hello edit-flow`

features/plugin-delete.feature

@@ -13,7 +13,7 @@ Feature: Delete WordPress plugins
     And the return code should be 0
 
   Scenario: Attempting to delete a plugin that doesn't exist
-    When I run `wp plugin delete edit-flow`
+    When I try `wp plugin delete edit-flow`
     Then STDOUT should be:
       """
       Success: Plugin already deleted.

features/plugin-install.feature

@@ -29,8 +29,13 @@ Feature: Install WordPress plugins
       """
       Warning: Destination folder already exists
       """
+    Then STDERR should contain:
+      """
+      Error: No plugins installed.
+      """
     And the wp-content/plugins/one-time-login directory should exist
     And the wp-content/plugins/one-time-login-master directory should not exist
+    And the return code should be 1
 
     When I run `wp plugin install https://github.com/runcommand/one-time-login/archive/master.zip --force`
     Then STDOUT should contain:
@@ -84,7 +89,12 @@ Feature: Install WordPress plugins
       """
       Warning: edit-flow: An unexpected error occurred. Something may be wrong with WordPress.org or this server’s configuration.
       """
+    And STDERR should contain:
+      """
+      Error: No plugins installed.
+      """
     And STDOUT should be empty
+    And the return code should be 1
 
     When I run `wp plugin install edit-flow`
     Then STDOUT should contain:
@@ -112,7 +122,7 @@ Feature: Install WordPress plugins
       """
     And the return code should be 1
 
-    When I run `wp plugin install user-switching`
+    When I try `wp plugin install user-switching`
     Then STDOUT should be:
       """
       Success: Plugin already installed.
@@ -145,6 +155,11 @@ Feature: Install WordPress plugins
       """
       Warning: Destination folder already exists. "{WORKING_DIR}/wp-content/plugins/akismet/"
       """
+    And STDERR should contain:
+      """
+      Error: No plugins installed.
+      """
+    And the return code should be 1
 
   Scenario: Don't attempt to rename ZIPs coming from a GitHub archive release/tag
     Given a WP install

features/plugin-uninstall.feature

@@ -22,10 +22,11 @@ Feature: Uninstall a WordPress plugin
       Warning: The 'akismet' plugin is active.
       Error: No plugins uninstalled.
       """
+    And STDOUT should be empty
     And the return code should be 1
 
   Scenario: Attempting to uninstall a plugin that doesn't exist
-    When I run `wp plugin uninstall edit-flow`
+    When I try `wp plugin uninstall edit-flow`
     Then STDOUT should be:
       """
       Success: Plugin already uninstalled.

features/plugin-update.feature

@@ -20,6 +20,7 @@ Feature: Update WordPress plugins
       """
       Error: Can't find the requested plugin's version 0.5.3 in the WordPress.org plugin repository (HTTP code 404).
       """
+    And the return code should be 1
 
     When I run `wp plugin list`
     Then STDOUT should be a table containing rows:
@@ -42,6 +43,7 @@ Feature: Update WordPress plugins
       """
       Error: --minor and --patch cannot be used together.
       """
+    And the return code should be 1
 
   Scenario: Exclude plugin updates from bulk updates.
     Given a WP install

features/plugin.feature

@@ -33,6 +33,8 @@ Feature: Manage WordPress plugins
       """
       The 'zombieLand' plugin could not be found.
       """
+    And STDOUT should be empty
+    And the return code should be 1
 
     # Check that the inner-plugin is not picked up
     When I run `mv {PLUGIN_DIR}/plugin1 {PLUGIN_DIR}/Zombieland/`
@@ -69,6 +71,12 @@ Feature: Manage WordPress plugins
       """
       The 'Zombieland' plugin is active.
       """
+    And STDERR should contain:
+      """
+      Error: No plugins uninstalled.
+      """
+    And STDOUT should be empty
+    And the return code should be 1
 
     When I run `wp plugin deactivate Zombieland`
     Then STDOUT should not be empty
@@ -88,10 +96,15 @@ Feature: Manage WordPress plugins
     And the {PLUGIN_DIR}/zombieland file should not exist
 
     When I try the previous command again
-    Then STDERR should contain:
+    Then STDERR should be:
+      """
+      Warning: The 'Zombieland' plugin could not be found.
+      """
+    And STDOUT should be:
       """
-      The 'Zombieland' plugin could not be found.
+      Success: Plugin already uninstalled.
       """
+    And the return code should be 0
 
   Scenario: Install a plugin, activate, then force install an older version of the plugin
     Given a WP install
@@ -124,6 +137,8 @@ Feature: Manage WordPress plugins
       """
       Error: Please specify one or more plugins, or use --all.
       """
+    And STDOUT should be empty
+    And the return code should be 1
 
     When I run `wp plugin update --all --format=summary | grep 'updated successfully from'`
     Then STDOUT should contain:
@@ -144,6 +159,7 @@ Feature: Manage WordPress plugins
       """
       Error: No plugins updated.
       """
+    And the return code should be 1
 
     When I run `wp plugin install wordpress-importer --version=0.5 --force`
     Then STDOUT should not be empty
@@ -157,6 +173,7 @@ Feature: Manage WordPress plugins
       """
       Error: Only updated 1 of 3 plugins.
       """
+    And the return code should be 1
 
   Scenario: Activate a network-only plugin on single site
     Given a WP install
@@ -215,7 +232,7 @@ Feature: Manage WordPress plugins
       | name            | status           |
       | akismet         | active           |
 
-    When I run `wp plugin activate akismet`
+    When I try `wp plugin activate akismet`
     Then STDERR should contain:
       """
       Warning: Plugin 'akismet' is already active.
@@ -224,6 +241,7 @@ Feature: Manage WordPress plugins
       """
       Success: Plugin already activated.
       """
+    And the return code should be 0
 
     When I run `wp plugin activate akismet --network`
     Then STDOUT should be:
@@ -232,7 +250,7 @@ Feature: Manage WordPress plugins
       Success: Network activated 1 of 1 plugins.
       """
 
-    When I run `wp plugin activate akismet --network`
+    When I try `wp plugin activate akismet --network`
     Then STDERR should be:
       """
       Warning: Plugin 'akismet' is already network active.
@@ -241,13 +259,15 @@ Feature: Manage WordPress plugins
       """
       Success: Plugin already network activated.
       """
+    And the return code should be 0
 
     When I try `wp plugin deactivate akismet`
     Then STDERR should be:
       """
       Warning: Plugin 'akismet' is network active and must be deactivated with --network flag.
       Error: No plugins deactivated.
       """
+    And STDOUT should be empty
     And the return code should be 1
 
     When I run `wp plugin deactivate akismet --network`
@@ -258,7 +278,7 @@ Feature: Manage WordPress plugins
       """
     And the return code should be 0
 
-    When I run `wp plugin deactivate akismet`
+    When I try `wp plugin deactivate akismet`
     Then STDERR should be:
       """
       Warning: Plugin 'akismet' isn't active.
@@ -375,6 +395,8 @@ Feature: Manage WordPress plugins
       """
       Error: The 'wordpress-importer' plugin could not be found.
       """
+    And STDOUT should be empty
+    And the return code should be 1
 
   Scenario: Deactivate and uninstall a plugin, part two
     Given a WP install
@@ -397,7 +419,8 @@ Feature: Manage WordPress plugins
       """
       Error: The 'wordpress-importer' plugin could not be found.
       """
-
+    And STDOUT should be empty
+    And the return code should be 1
 
   Scenario: Uninstall a plugin without deleting
     Given a WP install
@@ -465,7 +488,7 @@ Feature: Manage WordPress plugins
   Scenario: Ignore empty slugs
     Given a WP install
 
-    When I run `wp plugin install ''`
+    When I try `wp plugin install ''`
     Then STDERR should contain:
       """
       Warning: Ignoring ambigious empty slug value.
@@ -474,6 +497,7 @@ Feature: Manage WordPress plugins
       """
       Plugin installed successfully
       """
+    And the return code should be 0
 
   Scenario: Plugin hidden by "all_plugins" filter
     Given a WP install

features/theme-delete.feature

@@ -17,7 +17,7 @@ Feature: Delete WordPress themes
     When I run `wp theme delete p2`
     Then STDOUT should not be empty
 
-    When I run the previous command again
+    When I try the previous command again
     Then STDOUT should be:
       """
       Success: Theme already deleted.

features/theme-install.feature

@@ -19,7 +19,7 @@ Feature: Install WordPress themes
       """
     And the return code should be 1
 
-    When I run `wp theme install p2`
+    When I try `wp theme install p2`
     Then STDOUT should be:
       """
       Success: Theme already installed.
@@ -36,6 +36,7 @@ Feature: Install WordPress themes
       Warning: Couldn't find 'p2-not-a-theme' in the WordPress.org theme directory.
       Error: No themes installed.
       """
+    And STDOUT should be empty
     And the return code should be 1
 
   Scenario: Ensure automatic parent theme installation uses http cacher

features/theme-mod.feature

@@ -12,6 +12,8 @@ Feature: Manage WordPress theme mods
       """
       You must specify at least one mod or use --all.
       """
+    And STDOUT should be empty
+    And the return code should be 1
 
     When I run `wp theme mod set background_color 123456`
     And I run `wp theme mod get --all`
@@ -55,6 +57,8 @@ Feature: Manage WordPress theme mods
       """
       You must specify at least one mod or use --all.
       """
+    And STDOUT should be empty
+    And the return code should be 1
 
     When I run `wp theme mod remove background_color`
     Then STDOUT should be: