Merge pull request #492 from wp-cli/copilot/add-plugin-update-info

Display extension names during bulk updates

Author: swissspidy

features/plugin-update.feature

@@ -267,3 +267,25 @@ Feature: Update WordPress plugins
       """
       Success: Updated 1 of 1 plugins (1 skipped).
       """
+
+  @require-wp-5.2
+  Scenario: Updating all plugins should show the name of each plugin as it is updated
+    Given a WP install
+    And I run `wp plugin delete akismet`
+
+    When I run `wp plugin install health-check --version=1.5.0`
+    Then STDOUT should not be empty
+
+    When I run `wp plugin install wordpress-importer --version=0.5`
+    Then STDOUT should not be empty
+
+    When I try `wp plugin update --all`
+    Then STDOUT should contain:
+      """
+      Updating Health Check & Troubleshooting...
+      """
+
+    And STDOUT should contain:
+      """
+      Success: Updated 2 of 2 plugins.
+      """

features/theme-update.feature

@@ -154,3 +154,25 @@ Feature: Update WordPress themes
       """
       1.1.1
       """
+
+  @require-wp-4.5
+  Scenario: Updating all themes should show the name of each theme as it is updated
+    Given a WP install
+    And I run `wp theme delete --all --force`
+
+    When I run `wp theme install moina --version=1.0.2`
+    Then STDOUT should not be empty
+
+    When I run `wp theme install twentytwelve --version=1.0`
+    Then STDOUT should not be empty
+
+    When I try `wp theme update --all`
+    Then STDOUT should contain:
+      """
+      Updating Moina...
+      """
+
+    And STDOUT should contain:
+      """
+      Success: Updated 2 of 2 themes.
+      """

phpcs.xml.dist

@@ -61,6 +61,7 @@
 		<exclude-pattern>*/src/WP_CLI/CommandWithUpgrade\.php$</exclude-pattern>
 		<exclude-pattern>*/src/WP_CLI/(CommandWith|DestructivePlugin|DestructiveTheme)Upgrader\.php$</exclude-pattern>
 		<exclude-pattern>*/src/WP_CLI/Parse(Plugin|Theme)NameInput\.php$</exclude-pattern>
+		<exclude-pattern>*/src/WP_CLI/ExtensionUpgraderSkin\.php$</exclude-pattern>
 	</rule>
 
 	<!-- Exclude classes from UselessOverridingMethod sniff as the method is used for generating docs. -->

src/WP_CLI/CommandWithUpgrade.php

@@ -389,7 +389,14 @@ protected function get_upgrader( $assoc_args ) {
 		$force          = Utils\get_flag_value( $assoc_args, 'force', false );
 		$insecure       = Utils\get_flag_value( $assoc_args, 'insecure', false );
 		$upgrader_class = $this->get_upgrader_class( $force );
-		return Utils\get_upgrader( $upgrader_class, $insecure );
+
+		if ( ! class_exists( '\WP_Upgrader_Skin' ) ) {
+			if ( file_exists( ABSPATH . 'wp-admin/includes/class-wp-upgrader-skin.php' ) ) {
+				include ABSPATH . 'wp-admin/includes/class-wp-upgrader-skin.php';
+			}
+		}
+
+		return Utils\get_upgrader( $upgrader_class, $insecure, new ExtensionUpgraderSkin() );
 	}
 
 	protected function update_many( $args, $assoc_args ) {

src/WP_CLI/ExtensionUpgraderSkin.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace WP_CLI;
+
+use WP_CLI;
+
+/**
+ * An Upgrader Skin for extensions (plugins/themes) that displays which item is being updated
+ *
+ * @package wp-cli
+ */
+class ExtensionUpgraderSkin extends UpgraderSkin {
+
+	/**
+	 * Called before an update is performed.
+	 */
+	public function before() {
+		if ( isset( $this->plugin_info ) && is_array( $this->plugin_info ) && isset( $this->plugin_info['Name'] ) ) {
+			WP_CLI::log( sprintf( 'Updating %s...', html_entity_decode( $this->plugin_info['Name'], ENT_QUOTES, get_bloginfo( 'charset' ) ) ) );
+		} elseif ( isset( $this->theme_info ) && is_object( $this->theme_info ) && method_exists( $this->theme_info, 'get' ) ) {
+			WP_CLI::log( sprintf( 'Updating %s...', html_entity_decode( $this->theme_info->get( 'Name' ), ENT_QUOTES, get_bloginfo( 'charset' ) ) ) );
+		}
+	}
+}