Keep failed update output parseable for JSON and CSV (#529)

Co-authored-by: Pascal Birchler <pascalb@google.com>

Author: ekamran

features/plugin-update.feature

@@ -380,6 +380,37 @@ Feature: Update WordPress plugins
       Success: Updated 2 of 2 plugins.
       """
 
+  @require-wp-5.2 @skip-windows
+  Scenario: Failed plugin update keeps JSON output parseable
+    Given a WP install
+    And I run `wp plugin install wordpress-importer --version=0.5 --force`
+    And I run `chmod -w wp-content/plugins/wordpress-importer`
+
+    When I try `wp plugin update wordpress-importer --format=json`
+    Then STDOUT should be JSON containing:
+      """
+      [{"name":"wordpress-importer","old_version":"0.5","status":"Error"}]
+      """
+    And STDERR should be empty
+    And the return code should be 1
+
+    When I run `chmod +w wp-content/plugins/wordpress-importer`
+
+  @require-wp-5.2 @skip-windows
+  Scenario: Failed plugin update keeps CSV output parseable
+    Given a WP install
+    And I run `wp plugin install wordpress-importer --version=0.5 --force`
+    And I run `chmod -w wp-content/plugins/wordpress-importer`
+
+    When I try `wp plugin update wordpress-importer --format=csv`
+    Then STDOUT should be CSV containing:
+      | name               | old_version | status |
+      | wordpress-importer | 0.5         | Error  |
+    And STDERR should be empty
+    And the return code should be 1
+
+    When I run `chmod +w wp-content/plugins/wordpress-importer`
+
   # Skipped on Windows because of mkdir usage that would need to be refactored for compatibility.
   @require-wp-5.2 @skip-windows
   Scenario: Skip plugin update when plugin directory is a VCS checkout

src/WP_CLI/CommandWithUpgrade.php

@@ -880,6 +880,9 @@ static function ( $result ) {
 			$errors  = $skipped;
 			$skipped = null;
 		}
+		if ( ! empty( $assoc_args['format'] ) && in_array( $assoc_args['format'], [ 'json', 'csv' ], true ) && $errors ) {
+			WP_CLI::halt( 1 );
+		}
 		Utils\report_batch_operation_results( $this->item_type, 'update', $total_updated, $num_updated, $errors, $skipped );
 		if ( null !== $exclude ) {
 			WP_CLI::log( "Skipped updates for: $exclude" );