Merge pull request #33 from wp-cli/hidden-directories

Ensure hidden subdirectories of directories are ignored too

Author: danielbachhuber

features/find.feature

@@ -181,6 +181,8 @@ Feature: Find WordPress installs on the filesystem
   Scenario: Ignore hidden directories by default
     Given a WP install in 'subdir1'
     And a WP install in '.svn'
+    And I run `mkdir -p subdir2/.svn`
+    And a WP install in 'subdir2/.svn/wp-install'
 
     When I run `wp eval --skip-wordpress 'echo realpath( getenv( "RUN_DIR" ) );'`
     Then save STDOUT as {TEST_DIR}
@@ -194,5 +196,5 @@ Feature: Find WordPress installs on the filesystem
     When I run `wp find {TEST_DIR} --skip-ignored-paths --format=count`
     Then STDOUT should be:
       """
-      2
+      3
       """

src/Find_Command.php

@@ -200,7 +200,9 @@ private function recurse_directory( $path ) {
 			// Assume base path doesn't need comparison
 			$compared_path = preg_replace( '#^' . preg_quote( $this->base_path ) . '#', '', $path );
 			// Ignore all hidden system directories
-			if ( '/.' === substr( $compared_path, 0, 2 ) ) {
+			$bits = explode( '/', trim( $compared_path, '/' ) );
+			$current_dir = array_pop( $bits );
+			if ( $current_dir && '.' === $current_dir[0] ) {
 				$this->log( "Matched ignored path. Skipping recursion into '{$path}'" );
 				return;
 			}