Merge pull request #25 from wp-cli/23-invalid-directory

Error when invalid path provided; catch exceptions when unreadable

Author: danielbachhuber

features/find.feature

@@ -152,3 +152,12 @@ Feature: Find WordPress installs on the filesystem
       """
       0
       """
+
+  Scenario: Invalid path specified
+    Given an empty directory
+
+    When I try `wp find foo`
+    Then STDERR should be:
+      """
+      Error: Invalid path specified.
+      """

src/Find_Command.php

@@ -141,6 +141,9 @@ class Find_Command {
 	public function __invoke( $args, $assoc_args ) {
 		list( $path ) = $args;
 		$this->base_path = realpath( $path );
+		if ( ! $this->base_path ) {
+			WP_CLI::error( 'Invalid path specified.' );
+		}
 		$this->skip_ignored_paths = Utils\get_flag_value( $assoc_args, 'skip-ignored-paths' );
 		$this->max_depth = Utils\get_flag_value( $assoc_args, 'max_depth', false );
 		$this->verbose = Utils\get_flag_value( $assoc_args, 'verbose' );
@@ -196,7 +199,12 @@ private function recurse_directory( $path ) {
 		// Check all files and directories of this path to recurse
 		// into subdirectories.
 		$this->log( "Recusing into {$path}" );
-		$iterator = new RecursiveDirectoryIterator( $path, FilesystemIterator::SKIP_DOTS );
+		try {
+			$iterator = new RecursiveDirectoryIterator( $path, FilesystemIterator::SKIP_DOTS );
+		} catch( Exception $e ) {
+			$this->log( "Exception thrown '{$e->getMessage()}'. Skipping recursion into {$path}" );
+			return;
+		}
 		foreach( $iterator as $file_info ) {
 			if ( $file_info->isDir() ) {
 				$this->current_depth++;