Fix PHPStan error

swissspidy · swissspidy · commit 80d0130a078b · 2026-05-04T15:04:37.000+02:00
diff --git a/src/Media_Command.php b/src/Media_Command.php
@@ -1140,7 +1140,7 @@ private function find_duplicate_attachment( $basename ) {
 			);
 		}
 
-		$query = new \WP_Query(
+		$posts = get_posts(
 			array(
 				'post_type'              => 'attachment',
 				'post_status'            => 'any',
@@ -1153,8 +1153,11 @@ private function find_duplicate_attachment( $basename ) {
 			)
 		);
 
-		$posts = $query->posts;
-		return ! empty( $posts ) ? (int) $posts[0] : false;
+		if ( empty( $posts ) ) {
+			return false;
+		}
+
+		return $posts[0];
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -1140,7 +1140,7 @@ private function find_duplicate_attachment( $basename ) {`
`1140`	`1140`	`);`
`1141`	`1141`	`}`
`1142`	`1142`
`1143`		`- $query = new \WP_Query(`
	`1143`	`+ $posts = get_posts(`
`1144`	`1144`	`array(`
`1145`	`1145`	`'post_type' => 'attachment',`
`1146`	`1146`	`'post_status' => 'any',`
`@@ -1153,8 +1153,11 @@ private function find_duplicate_attachment( $basename ) {`
`1153`	`1153`	`)`
`1154`	`1154`	`);`
`1155`	`1155`
`1156`		`- $posts = $query->posts;`
`1157`		`- return ! empty( $posts ) ? (int) $posts[0] : false;`
	`1156`	`+ if ( empty( $posts ) ) {`
	`1157`	`+ return false;`
	`1158`	`+ }`
	`1159`	`+`
	`1160`	`+ return $posts[0];`
`1158`	`1161`	`}`
`1159`	`1162`
`1160`	`1163`	`/**`