Replace env var tests with actual Git/SSH interaction tests

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>

Author: Copilot

features/package-install.feature

@@ -1263,46 +1263,19 @@ Feature: Install WP-CLI packages
       """
     And STDOUT should be empty
 
-  Scenario: Install a package with --no-interaction flag sets environment variables
+  @github-api
+  Scenario: Install package with --no-interaction fails fast on Git authentication errors
     Given an empty directory
-    And a composer.json file:
-      """
-      {
-        "repositories": {
-          "test" : {
-            "type": "path",
-            "url": "./dummy-package/"
-          },
-          "wp-cli": {
-            "type": "composer",
-            "url": "https://wp-cli.org/package-index/"
-          }
-        }
-      }
-      """
-    And a dummy-package/composer.json file:
-      """
-      {
-        "name": "wp-cli/restful",
-        "description": "Test package for no-interaction flag",
-        "scripts": {
-          "post-install-cmd": [
-            "@php -r \"echo 'GIT_TERMINAL_PROMPT=' . getenv('GIT_TERMINAL_PROMPT') . PHP_EOL;\"",
-            "@php -r \"echo 'GIT_SSH_COMMAND=' . getenv('GIT_SSH_COMMAND') . PHP_EOL;\""
-          ]
-        }
-      }
-      """
-    When I run `WP_CLI_PACKAGES_DIR=. wp package install wp-cli/restful --no-interaction`
-    Then STDOUT should contain:
-      """
-      GIT_TERMINAL_PROMPT=0
-      """
-    And STDOUT should contain:
-      """
-      GIT_SSH_COMMAND=ssh -o BatchMode=yes
-      """
-    And STDOUT should contain:
+
+    # Try to install from a repository that requires authentication
+    # With --no-interaction and GIT_TERMINAL_PROMPT=0, Git will fail immediately
+    # instead of prompting for credentials
+    When I try `wp package install git@github.com:wp-cli-private-test/authentication-required.git --no-interaction`
+    Then the return code should be 1
+    # The command should fail fast without hanging
+    And STDERR should contain:
       """
-      Success: Package installed
+      Package installation failed
       """
+    # Git should report it couldn't authenticate, not prompt
+    And STDERR should match /fatal:|Could not read from remote repository|Repository not found/

features/package-update.feature

@@ -195,51 +195,21 @@ Feature: Update WP-CLI packages
       """
     And the return code should be 1
 
-  Scenario: Update packages with --no-interaction flag sets environment variables
+  @github-api
+  Scenario: Update packages with --no-interaction completes without prompting
     Given an empty directory
-    And a composer.json file:
-      """
-      {
-        "repositories": {
-          "test" : {
-            "type": "path",
-            "url": "./dummy-package/"
-          },
-          "wp-cli": {
-            "type": "composer",
-            "url": "https://wp-cli.org/package-index/"
-          }
-        },
-        "require": {
-          "wp-cli/restful": "*"
-        }
-      }
-      """
-    And a dummy-package/composer.json file:
-      """
-      {
-        "name": "wp-cli/restful",
-        "version": "1.0.0",
-        "description": "Test package for no-interaction flag",
-        "scripts": {
-          "post-update-cmd": [
-            "@php -r \"echo 'GIT_TERMINAL_PROMPT=' . getenv('GIT_TERMINAL_PROMPT') . PHP_EOL;\"",
-            "@php -r \"echo 'GIT_SSH_COMMAND=' . getenv('GIT_SSH_COMMAND') . PHP_EOL;\""
-          ]
-        }
-      }
-      """
-
-    When I run `WP_CLI_PACKAGES_DIR=. wp package update --no-interaction`
-    Then STDOUT should contain:
-      """
-      GIT_TERMINAL_PROMPT=0
-      """
-    And STDOUT should contain:
+
+    # Install a real package
+    When I run `wp package install danielbachhuber/wp-cli-reset-post-date-command`
+    Then STDOUT should contain:
       """
-      GIT_SSH_COMMAND=ssh -o BatchMode=yes
+      Success: Package installed.
       """
-    And STDOUT should contain:
+
+    # Update with --no-interaction should complete without hanging
+    When I run `wp package update --no-interaction`
+    Then STDOUT should contain:
       """
       Packages updated.
       """
+    And STDERR should be empty

features/package.feature

@@ -209,50 +209,20 @@ Feature: Manage WP-CLI packages
       {NO_SUCH_PACKAGE_COMPOSER_JSON}
       """
 
-  Scenario: Uninstall a package with --no-interaction flag sets environment variables
+  @github-api
+  Scenario: Uninstall a package with --no-interaction prevents Git credential prompts
     Given an empty directory
-    And a composer.json file:
-      """
-      {
-        "repositories": {
-          "test" : {
-            "type": "path",
-            "url": "./dummy-package/"
-          },
-          "wp-cli": {
-            "type": "composer",
-            "url": "https://wp-cli.org/package-index/"
-          }
-        },
-        "require": {
-          "wp-cli/restful": "*"
-        }
-      }
-      """
-    And a dummy-package/composer.json file:
-      """
-      {
-        "name": "wp-cli/restful",
-        "version": "1.0.0",
-        "description": "Test package for no-interaction flag",
-        "scripts": {
-          "pre-uninstall-cmd": [
-            "@php -r \"echo 'GIT_TERMINAL_PROMPT=' . getenv('GIT_TERMINAL_PROMPT') . PHP_EOL;\"",
-            "@php -r \"echo 'GIT_SSH_COMMAND=' . getenv('GIT_SSH_COMMAND') . PHP_EOL;\""
-          ]
-        }
-      }
-      """
 
-    When I run `WP_CLI_PACKAGES_DIR=. wp package uninstall wp-cli/restful --no-interaction`
+    # Install a real package first
+    When I run `wp package install danielbachhuber/wp-cli-reset-post-date-command`
     Then STDOUT should contain:
       """
-      GIT_TERMINAL_PROMPT=0
-      """
-    And STDOUT should contain:
-      """
-      GIT_SSH_COMMAND=ssh -o BatchMode=yes
+      Success: Package installed.
       """
+
+    # Uninstall with --no-interaction should complete without hanging
+    When I run `wp package uninstall danielbachhuber/wp-cli-reset-post-date-command --no-interaction`
+    Then STDERR should be empty
     And STDOUT should contain:
       """
       Success: Uninstalled package.