Merge pull request #63 from wp-cli/windows-check

Steal WP-CLI's `is_windows()` check for `Shell`

Author: danielbachhuber

lib/cli/Shell.php

@@ -28,7 +28,7 @@ static public function columns() {
 		static $columns;
 
 		if ( null === $columns ) {
-			if (stripos(PHP_OS, 'indows') === false) {
+			if ( ! self::is_windows() ) {
 				$columns = (int) exec('/usr/bin/env tput cols');
 			}
 
@@ -71,6 +71,16 @@ static public function isPiped() {
 	static public function hide($hidden = true) {
 		system( 'stty ' . ( $hidden? '-echo' : 'echo' ) );
 	}
+
+	/**
+	 * Is this shell in Windows?
+	 *
+	 * @return bool
+	 */
+	static private function is_windows() {
+		return strtoupper(substr(PHP_OS, 0, 3)) === 'WIN';
+	}
+
 }
 
 ?>