-
Notifications
You must be signed in to change notification settings - Fork 85
Add strict slug validation for plugin-tests and theme-tests commands #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bc6d673
Initial plan
Copilot f29a0cc
Add validation to reject plugin/theme slugs ending with slashes
Copilot 0f035f8
Make slug validation stricter to only allow alphanumeric and dashes
Copilot 6ceee4f
Remove unnecessary escape for dash in regex character class
Copilot 65d0c45
Fix scaffold block test
swissspidy e97b194
Allow underscores in plugin/theme slugs for test scaffolding
Copilot 169fe4a
Merge branch 'main' into copilot/fix-plugin-name-slash-issue
swissspidy 75e3cfd
Update features/scaffold-plugin-tests.feature
swissspidy 191afb2
Update features/scaffold-theme-tests.feature
swissspidy af55fd0
Validate derived slugs from --dir option to prevent corrupted bootstr…
Copilot eba745a
Move slug validation before directory checks to fix failing tests
Copilot 52bfe0f
Merge branch 'main' into copilot/fix-plugin-name-slash-issue
swissspidy dd64f57
Fix test
swissspidy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.