partial revert, add another test

Author: swissspidy

features/scaffold-package-readme.feature

@@ -32,7 +32,7 @@ Feature: Scaffold a README.md file for an existing package
     When I run `wp package path`
     Then save STDOUT as {PACKAGE_PATH}
 
-    When I run `wp scaffold package wp-cli/default-readme`
+    When I try `wp scaffold package wp-cli/default-readme`
     Then STDOUT should contain:
       """
       Success: Created package readme.
@@ -66,7 +66,7 @@ Feature: Scaffold a README.md file for an existing package
     When I run `wp package path`
     Then save STDOUT as {PACKAGE_PATH}
 
-    When I run `wp scaffold package wp-cli/custom-branch`
+    When I try `wp scaffold package wp-cli/custom-branch`
     Then STDOUT should contain:
       """
       Success: Created package readme.
@@ -90,7 +90,7 @@ Feature: Scaffold a README.md file for an existing package
   Scenario: Scaffold a README.md requiring a nightly build
     Given an empty directory
 
-    When I run `wp scaffold package wp-cli/foo --dir=foo --require_wp_cli='>=0.24.0-alpha'`
+    When I try `wp scaffold package wp-cli/foo --dir=foo --require_wp_cli='>=0.24.0-alpha'`
     Then STDOUT should contain:
       """
       Success: Created package readme.
@@ -115,7 +115,7 @@ Feature: Scaffold a README.md file for an existing package
   Scenario: Scaffold a README.md requiring the latest stable release
     Given an empty directory
 
-    When I run `wp scaffold package wp-cli/foo --dir=foo --require_wp_cli='*'`
+    When I try `wp scaffold package wp-cli/foo --dir=foo --require_wp_cli='*'`
     Then STDOUT should contain:
       """
       Success: Created package readme.
@@ -313,10 +313,20 @@ Feature: Scaffold a README.md file for an existing package
     When I try `wp scaffold package-readme foo`
     Then STDERR should be:
       """
-      Error: Command 'profile' is not registered. Make sure it is loaded before running package-readme.
+      Error: Missing one or more commands defined in composer.json -> extra -> commands.
       """
     And the return code should be 1
 
+  Scenario: Does not error when commands are specified and present
+    Given an empty directory
+    When I try `wp scaffold package wp-cli/foo --dir=foo`
+    And I try `composer install -d foo`
+    And I try `wp scaffold package-readme foo`
+    Then STDERR should not contain:
+      """
+      Error: Missing one or more commands defined in composer.json -> extra -> commands.
+      """
+
   Scenario: README for a bundled command
     Given an empty directory
     And a foo/composer.json file:

src/ScaffoldPackageCommand.php

@@ -139,7 +139,7 @@ public function package( $args, $assoc_args ) {
 		}
 
 		if ( ! Utils\get_flag_value( $assoc_args, 'skip-readme' ) ) {
-			WP_CLI::runcommand( "scaffold package-readme {$package_dir} {$force_flag}", array( 'launch' => true ) );
+			WP_CLI::runcommand( "scaffold package-readme {$package_dir} {$force_flag}", array( 'launch' => false ) );
 		}
 
 		if ( ! Utils\get_flag_value( $assoc_args, 'skip-github' ) ) {
@@ -309,9 +309,10 @@ public function package_readme( $args, $assoc_args ) {
 			$cmd_dump                = WP_CLI::runcommand(
 				'cli cmd-dump',
 				[
-					'launch' => false,
-					'return' => true,
-					'parse'  => 'json',
+					'launch'       => false,
+					'return'       => true,
+					'parse'        => 'json',
+					'command_args' => [ "--path=$package_dir" ],
 				]
 			);
 			foreach ( $composer_obj['extra']['commands'] as $command ) {
@@ -333,7 +334,7 @@ public function package_readme( $args, $assoc_args ) {
 				} while ( $parent_command && $bits );
 
 				if ( empty( $parent_command ) ) {
-					WP_CLI::error( "Command '{$command}' is not registered. Make sure it is loaded before running package-readme." );
+					WP_CLI::error( 'Missing one or more commands defined in composer.json -> extra -> commands.' );
 				}
 
 				$longdesc = isset( $parent_command['longdesc'] ) ? $parent_command['longdesc'] : '';