Skip to content

Commit be76a23

Browse files
Copilotswissspidy
andcommitted
Skip README generation when package installation is skipped
When --skip-install is used, the package is not installed, so commands won't be loaded. This would cause package-readme to fail with the missing commands error. Instead, we now skip README generation with a warning message explaining that commands must be loaded for complete documentation. Users who want to skip installation but still generate a README can manually run 'wp scaffold package-readme' after ensuring commands are loaded via wp-cli.yml or package installation. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
1 parent 99cd149 commit be76a23

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/ScaffoldPackageCommand.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,12 @@ public function package( $args, $assoc_args ) {
145145
if ( ! Utils\get_flag_value( $assoc_args, 'skip-install' ) ) {
146146
Process::create( "composer install --working-dir {$package_dir}" )->run();
147147
WP_CLI::runcommand( "package install {$package_dir}", array( 'launch' => false ) );
148-
}
149148

150-
if ( ! Utils\get_flag_value( $assoc_args, 'skip-readme' ) ) {
151-
WP_CLI::runcommand( "scaffold package-readme {$package_dir} {$force_flag}", array( 'launch' => true ) );
149+
if ( ! Utils\get_flag_value( $assoc_args, 'skip-readme' ) ) {
150+
WP_CLI::runcommand( "scaffold package-readme {$package_dir} {$force_flag}", array( 'launch' => true ) );
151+
}
152+
} elseif ( ! Utils\get_flag_value( $assoc_args, 'skip-readme' ) ) {
153+
WP_CLI::warning( 'Skipping README generation because package is not installed. Commands must be loaded for complete documentation.' );
152154
}
153155
}
154156

0 commit comments

Comments
 (0)