Skip to content

Fix code coverage collection test #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 2 commits into from
Mar 9, 2025
Merged

Fix code coverage collection test #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
618d2df
Require newer wp-cli-tests version in scaffolded package
swissspidy Mar 9, 2025
1874b86
Update tests
swissspidy Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions features/scaffold-package-readme.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Feature: Scaffold a README.md file for an existing package
And the {PACKAGE_PATH}/local/wp-cli/default-readme/README.md file should exist
And the {PACKAGE_PATH}/local/wp-cli/default-readme/README.md file should contain:
"""
Installing this package requires WP-CLI v2.5 or greater. Update to the latest stable release with `wp cli update`.
Installing this package requires WP-CLI v2.11 or greater. Update to the latest stable release with `wp cli update`.
"""
And the {PACKAGE_PATH}/local/wp-cli/default-readme/README.md file should contain:
"""
Expand Down Expand Up @@ -76,7 +76,7 @@ Feature: Scaffold a README.md file for an existing package
And the {PACKAGE_PATH}/local/wp-cli/custom-branch/README.md file should exist
And the {PACKAGE_PATH}/local/wp-cli/custom-branch/README.md file should contain:
"""
Installing this package requires WP-CLI v2.5 or greater. Update to the latest stable release with `wp cli update`.
Installing this package requires WP-CLI v2.11 or greater. Update to the latest stable release with `wp cli update`.
"""
And the {PACKAGE_PATH}/local/wp-cli/custom-branch/README.md file should contain:
"""
Expand Down Expand Up @@ -152,10 +152,10 @@ Feature: Scaffold a README.md file for an existing package
"files": [ "command.php" ]
},
"require": {
"wp-cli/wp-cli": "^2.5"
"wp-cli/wp-cli": "^2.11"
},
"require-dev": {
"wp-cli/wp-cli-tests": "^3.0.11"
"wp-cli/wp-cli-tests": "^4.3.9"
},
"extra": {
"readme": {
Expand Down Expand Up @@ -333,7 +333,7 @@ Feature: Scaffold a README.md file for an existing package
},
"require-dev": {
"wp-cli/wp-cli": "*",
"wp-cli/wp-cli-tests": "^3.0.11"
"wp-cli/wp-cli-tests": "^4.3.9"
},
"extra": {
"bundled": true
Expand Down
6 changes: 3 additions & 3 deletions features/scaffold-package.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Feature: Scaffold WP-CLI commands
And the {PACKAGE_PATH}/local/wp-cli/foo/composer.json file should contain:
"""
"require": {
"wp-cli/wp-cli": "^2.5"
"wp-cli/wp-cli": "^2.11"
},
"""
And the {PACKAGE_PATH}/local/wp-cli/foo/hello-world-command.php file should exist
Expand Down Expand Up @@ -159,7 +159,7 @@ Feature: Scaffold WP-CLI commands
s
"""

When I run `wp scaffold package wp-cli/same-package --skip-tests --skip-github`
When I try `wp scaffold package wp-cli/same-package --skip-tests --skip-github`
Then STDOUT should contain:
"""
Success: Created package files
Expand All @@ -176,7 +176,7 @@ Feature: Scaffold WP-CLI commands
"""
And the return code should be 0

When I run `wp package uninstall wp-cli/same-package`
When I try `wp package uninstall wp-cli/same-package`
Then STDOUT should contain:
"""
Success: Uninstalled package.
Expand Down
4 changes: 2 additions & 2 deletions src/ScaffoldPackageCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ class ScaffoldPackageCommand {
* [--require_wp_cli=<version>]
* : Required WP-CLI version for the package.
* ---
* default: ^2.5
* default: ^2.11
* ---
*
* [--require_wp_cli_tests=<version>]
* : Required WP-CLI testing framework version for the package.
* ---
* default: ^3.0.11
* default: ^4.3.9
* ---

* [--skip-tests]
Expand Down