Skip to content

Fix failing tests due to Mustache dependency conflict#280

Merged
swissspidy merged 2 commits intomainfrom
fix/tests
Mar 13, 2026
Merged

Fix failing tests due to Mustache dependency conflict#280
swissspidy merged 2 commits intomainfrom
fix/tests

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@github-actions github-actions bot added bug dependencies Pull requests that update a dependency file labels Mar 13, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default and tested minimum WP-CLI version from 2.12 to 2.13 across various scaffolding features. This adjustment is crucial for resolving existing test failures related to dependency conflicts, specifically with the Mustache library, thereby enhancing the reliability of the package scaffolding process.

Highlights

  • WP-CLI Version Update: The minimum required WP-CLI version for scaffolded packages and feature tests has been updated from v2.12 to v2.13.
  • Test Stability: This change resolves failing tests that were likely caused by a Mustache dependency conflict, ensuring the stability of the scaffolding features.
Changelog
  • features/scaffold-package-readme.feature
    • Updated the required WP-CLI version from v2.12 to v2.13 in the generated README.md content for package scaffolding.
    • Modified the wp-cli/wp-cli dependency requirement in embedded composer.json files from ^2.12 to ^2.13.
  • features/scaffold-package.feature
    • Updated the wp-cli/wp-cli dependency requirement in the composer.json snippet used for scaffolding tests from ^2.12 to ^2.13.
  • src/ScaffoldPackageCommand.php
    • Changed the default value for the --require_wp_cli option from ^2.12 to ^2.13.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the required WP-CLI version from ^2.12 to ^2.13 to resolve a dependency conflict. The changes are applied consistently across the command's default value and the corresponding test files. My review includes one suggestion to improve the maintainability of the test suite by reducing the duplication of the version string in test files.

@swissspidy swissspidy marked this pull request as ready for review March 13, 2026 08:59
@swissspidy swissspidy requested a review from a team as a code owner March 13, 2026 08:59
Copilot AI review requested due to automatic review settings March 13, 2026 08:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the default WP-CLI version constraint used by wp scaffold package to avoid dependency conflicts (notably around transitive dependencies like Mustache) and aligns the acceptance tests with the new default.

Changes:

  • Bump --require_wp_cli default from ^2.12 to ^2.13.
  • Update Behat feature expectations for scaffolded composer.json and generated README text to reflect the new minimum.
  • Keep scaffold/readme behaviors consistent by aligning tests for both package scaffolding and README scaffolding.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/ScaffoldPackageCommand.php Updates the documented default for --require_wp_cli to ^2.13.
features/scaffold-package.feature Updates expected scaffolded composer.json WP-CLI requirement to ^2.13.
features/scaffold-package-readme.feature Updates expected README/install text and embedded composer snippets to reference WP-CLI v2.13 / ^2.13.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@swissspidy swissspidy merged commit 4da876e into main Mar 13, 2026
11 of 12 checks passed
@swissspidy swissspidy deleted the fix/tests branch March 13, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug dependencies Pull requests that update a dependency file scope:testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants